Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8276987: Optimized upcall stub should be printed with -XX:+PrintStubCode #611

Closed
wants to merge 1 commit into from

Conversation

nick-arm
Copy link
Member

@nick-arm nick-arm commented Nov 12, 2021

That would allow it to be found by JMH's profasm which uses -XX:+PrintStubCode to collect the addresses of stubs. Note that JMH at the moment can't actually parse the stubs printed by trace_new_stub (because they have a "Decoding ..." prefix and don't include the end address), but that can be fixed on the JMH side.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • JDK-8276987: Optimized upcall stub should be printed with -XX:+PrintStubCode

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/panama-foreign pull/611/head:pull/611
$ git checkout pull/611

Update a local copy of the PR:
$ git checkout pull/611
$ git pull https://git.openjdk.java.net/panama-foreign pull/611/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 611

View PR using the GUI difftool:
$ git pr show -t 611

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/panama-foreign/pull/611.diff

That would allow it to be found by JMH's profasm which uses
-XX:+PrintStubCode to collect the addresses of stubs.  Note that JMH at
the moment can't actually parse the stubs printed by
trace_new_stub (because they have a "Decoding ..." prefix and don't
include the end address), but that can be fixed on the JMH side.
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 12, 2021

👋 Welcome back ngasson! A progress list of the required criteria for merging this PR into foreign-memaccess+abi will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 12, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 12, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Nov 12, 2021

@nick-arm This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276987: Optimized upcall stub should be printed with -XX:+PrintStubCode

Reviewed-by: jvernee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 97 new commits pushed to the foreign-memaccess+abi branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the foreign-memaccess+abi branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 12, 2021
@JornVernee
Copy link
Member

@JornVernee JornVernee commented Nov 12, 2021

Thanks!

I think in the future we could probably also remove TraceOptimziedUpcallStubs in favor of PrintStubCode.

@nick-arm
Copy link
Member Author

@nick-arm nick-arm commented Nov 15, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Nov 15, 2021

Going to push as commit 4029dd5.
Since your change was applied there have been 192 commits pushed to the foreign-memaccess+abi branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 15, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 15, 2021

@nick-arm Pushed as commit 4029dd5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated
2 participants