8276987: Optimized upcall stub should be printed with -XX:+PrintStubCode

[nick-arm]

That would allow it to be found by JMH's profasm which uses -XX:+PrintStubCode to collect the addresses of stubs. Note that JMH at the moment can't actually parse the stubs printed by trace_new_stub (because they have a "Decoding ..." prefix and don't include the end address), but that can be fixed on the JMH side.

---

Progress

• Change must not contain extraneous whitespace
• Change must be properly reviewed

Issue

• JDK-8276987: Optimized upcall stub should be printed with -XX:+PrintStubCode

Reviewers

• Jorn Vernee (@JornVernee - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/panama-foreign pull/611/head:pull/611
$ git checkout pull/611

Update a local copy of the PR:
$ git checkout pull/611
$ git pull https://git.openjdk.java.net/panama-foreign pull/611/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 611

View PR using the GUI difftool:
$ git pr show -t 611

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/panama-foreign/pull/611.diff

[bridgekeeper]

👋 Welcome back ngasson! A progress list of the required criteria for merging this PR into foreign-memaccess+abi will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 00: Full (1191288f)

[openjdk]

@nick-arm This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276987: Optimized upcall stub should be printed with -XX:+PrintStubCode

Reviewed-by: jvernee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 97 new commits pushed to the foreign-memaccess+abi branch:

• 9e9ba2e: 8275646: Implement optimized upcall stubs on AArch64
• 330a9f8: Automatic merge of master into foreign-memaccess+abi
• a4e8d06: Automatic merge of jdk:master into master
• d95299a: 8276634: Remove usePlainDatagramSocketImpl option from the test DatagramChannel/SendReceiveMaxSize.java
• 3c0faa7: 8276173: Clean up and remove unneeded casts in HeapDumper
• 323d201: 8275506: Rename allocated_on_stack to allocated_on_stack_or_embedded
• 96c396b: 8276151: AArch64: Incorrect result for double to int vector conversion
• 7281861: 8272065: jcmd cannot rely on the old core reflection implementation which will be changed after JEP 416
• 8e17ce0: 8275185: Remove dead code and clean up jvmstat LocalVmManager
• 396132f: 8275509: ModuleDescriptor.hashCode isn't reproducible across builds
• ... and 87 more: https://git.openjdk.java.net/panama-foreign/compare/818dcfc8e7c0383efb3438a19fc7e24bfdbfcae7...foreign-memaccess+abi

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the foreign-memaccess+abi branch, type /integrate in a new comment.

[JornVernee]

Thanks!

I think in the future we could probably also remove TraceOptimziedUpcallStubs in favor of PrintStubCode.

[nick-arm]

/integrate

[openjdk]

Going to push as commit 4029dd5.
Since your change was applied there have been 192 commits pushed to the foreign-memaccess+abi branch:

• 0d3ad18: Merge master
• 4ae4c4c: Automatic merge of jdk:master into master
• 710f496: 8273277: C2: Move conditional negation into rc_predicate
• 6b833db: 8275329: ZGC: vmTestbase/gc/gctests/SoftReference/soft004/soft004.java fails with assert(_phases->length() <= 1000) failed: Too many recored phases?
• 1e941de: 8275197: Remove unused fields in ThaiBuddhistChronology
• 6954b98: 8186670: Implement _onSpinWait() intrinsic for AArch64
• 3445e50: 8276265: jcmd man page is outdated
• 0ca0acf: 8276947: Clarify how DateTimeFormatterBuilder.appendFraction handles value ranges
• b0d7a9d: 8276994: java/nio/channels/Channels/TransferTo.java leaves multi-GB files in /tmp
• 8aae88b: 8276763: java/nio/channels/SocketChannel/AdaptorStreams.java fails with "SocketTimeoutException: Read timed out"
• ... and 182 more: https://git.openjdk.java.net/panama-foreign/compare/818dcfc8e7c0383efb3438a19fc7e24bfdbfcae7...foreign-memaccess+abi

Your commit was automatically rebased without conflicts.

[openjdk]

@nick-arm Pushed as commit 4029dd5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.