8282235: jextract crashes when a Java keyword is used in as a function pointer typedef parameter name

[sundararajana]

Missed transforming function typedef parameter names as java safe identifiers.

---

Progress

• Change must not contain extraneous whitespace
• Change must be properly reviewed

Issue

• JDK-8282235: jextract crashes when a Java keyword is used in as a function pointer typedef parameter name

Reviewers

• Maurizio Cimadamore (@mcimadamore - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/panama-foreign pull/653/head:pull/653
$ git checkout pull/653

Update a local copy of the PR:
$ git checkout pull/653
$ git pull https://git.openjdk.java.net/panama-foreign pull/653/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 653

View PR using the GUI difftool:
$ git pr show -t 653

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/panama-foreign/pull/653.diff

[bridgekeeper]

👋 Welcome back sundar! A progress list of the required criteria for merging this PR into foreign-jextract will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 00: Full (12ac3070)

[mcimadamore]

Do we do this for regular native functions?

e.g.

int foo(int abstract);

[sundararajana]

We already call Utils.javaSafeIdentifier() elsewhere. So this is already taken care of (8261893)

[mcimadamore]

thanks for the explanation

[mcimadamore]

Looks good

[openjdk]

@sundararajana This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8282235: jextract crashes when a Java keyword is used in as a function pointer typedef parameter name

Reviewed-by: mcimadamore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the foreign-jextract branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the foreign-jextract branch, type /integrate in a new comment.

[sundararajana]

/integrate

[openjdk]

Going to push as commit 11efb79.

[openjdk]

@sundararajana Pushed as commit 11efb79.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.