8275584: Incorrect stack spilling in CallArranger on MacOS/AArch64

[nick-arm]

This patch adds special handling for argument spilling on M1 Mac which does not follow the standard AArch64. In the standard ABI arguments are first extended to the full 64-bit register width and then spilled but on macOS the arguments are spilled according to their original width and packed using theior natural. @JornVernee did most of the work to support this but there were a few issues remaining related to structspilling which I've fixed up in the last commit here.

---

Progress

• Change must not contain extraneous whitespace
• Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

• JDK-8275584: Incorrect stack spilling in CallArranger on MacOS/AArch64

Reviewers

• Jorn Vernee (@JornVernee - Committer)

Contributors

• Jorn Vernee <jvernee@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/panama-foreign pull/746/head:pull/746
$ git checkout pull/746

Update a local copy of the PR:
$ git checkout pull/746
$ git pull https://git.openjdk.org/panama-foreign pull/746/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 746

View PR using the GUI difftool:
$ git pr show -t 746

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/panama-foreign/pull/746.diff

[bridgekeeper]

👋 Welcome back ngasson! A progress list of the required criteria for merging this PR into foreign-memaccess+abi will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 02: Full - Incremental (d6b97f4b)
• 01: Full - Incremental (8af03ba1)
• 00: Full (c24940d0)

[nick-arm]

/contributor add @JornVernee

[openjdk]

@nick-arm
Contributor Jorn Vernee <jvernee@openjdk.org> successfully added.

[JornVernee]

Thanks again for fixing.

[openjdk]

@nick-arm This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275584: Incorrect stack spilling in CallArranger on MacOS/AArch64

Co-authored-by: Jorn Vernee <jvernee@openjdk.org>
Reviewed-by: jvernee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 123 new commits pushed to the foreign-memaccess+abi branch:

• 0714b72: 8295780: API doc enhancement needed for MemorySegment.get/setUtf8String, MemoryAddress.ofLong
• 4786b16: 8294871: The spec on the method MemorySegment::segmentOffset() should be corrected
• 916c746: Add @sealedGraph tag to MemoryLayout
• 595945b: Merge master
• f42e941: Automatic merge of jdk:master into master
• 0c13d66: 8295530: Update Zlib Data Compression Library to Version 1.2.13
• 15bebf9: 8295666: Linux x86 build fails after 8292591
• 5064718: 8294460: CodeSection::alignment checks for CodeBuffer::SECT_STUBS incorrectly
• 8b010e0: 8030616: sun/management/jmxremote/bootstrap/RmiBootstrapTest fails intermittently with cannot find a free port
• b35922b: 8295714: GHA ::set-output is deprecated and will be removed
• ... and 113 more: https://git.openjdk.org/panama-foreign/compare/15a1ec23efc74e5e483168cd8d75cabb0148e544...foreign-memaccess+abi

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the foreign-memaccess+abi branch, type /integrate in a new comment.

[nick-arm]

I'll integrate this one now unless there's any more reviews/comments?

[JornVernee]

I think you're good to go :)

[nick-arm]

/integrate

[openjdk]

Going to push as commit d575ec5.
Since your change was applied there have been 123 commits pushed to the foreign-memaccess+abi branch:

• 0714b72: 8295780: API doc enhancement needed for MemorySegment.get/setUtf8String, MemoryAddress.ofLong
• 4786b16: 8294871: The spec on the method MemorySegment::segmentOffset() should be corrected
• 916c746: Add @sealedGraph tag to MemoryLayout
• 595945b: Merge master
• f42e941: Automatic merge of jdk:master into master
• 0c13d66: 8295530: Update Zlib Data Compression Library to Version 1.2.13
• 15bebf9: 8295666: Linux x86 build fails after 8292591
• 5064718: 8294460: CodeSection::alignment checks for CodeBuffer::SECT_STUBS incorrectly
• 8b010e0: 8030616: sun/management/jmxremote/bootstrap/RmiBootstrapTest fails intermittently with cannot find a free port
• b35922b: 8295714: GHA ::set-output is deprecated and will be removed
• ... and 113 more: https://git.openjdk.org/panama-foreign/compare/15a1ec23efc74e5e483168cd8d75cabb0148e544...foreign-memaccess+abi

Your commit was automatically rebased without conflicts.

[openjdk]

@nick-arm Pushed as commit d575ec5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.