8312186: TestStringEncodingFails for UTF-32

[JornVernee]

The test is failing because there are now several UTF 32-based char sets in StandardCharsets, and the FFM API can not handle these yet.

This patch adds support for the UTF 32 based char sets to MemorySegment::getString(long, Charset), MemorySegment::setString(long, String, Charset), and SegmentAllocator::allocateFrom(String, Charset).

---

Progress

• Change must not contain extraneous whitespace
• Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

• JDK-8312186: TestStringEncodingFails for UTF-32 (Bug - P2)

Reviewers

• Maurizio Cimadamore (@mcimadamore - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/panama-foreign.git pull/847/head:pull/847
$ git checkout pull/847

Update a local copy of the PR:
$ git checkout pull/847
$ git pull https://git.openjdk.org/panama-foreign.git pull/847/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 847

View PR using the GUI difftool:
$ git pr show -t 847

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/panama-foreign/pull/847.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jvernee! A progress list of the required criteria for merging this PR into foreign-memaccess+abi will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[JornVernee]

Note that I dropped the ValueLayout. prefix here and below to make the references to JAVA_BYTE consistent throughout the file.

[mlbridge]

Webrevs

• 00: Full (86d21be0)

[mcimadamore]

Looks great!

[openjdk]

@JornVernee This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312186: TestStringEncodingFails for UTF-32

Reviewed-by: mcimadamore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the foreign-memaccess+abi branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the foreign-memaccess+abi branch, type /integrate in a new comment.

[JornVernee]

/integrate

[openjdk]

Going to push as commit 7983194.

[openjdk]

@JornVernee Pushed as commit 7983194.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.