Skip to content

Commit b09bdb3

Browse files
Jatin BhatejaBhavana Kilambi
andcommitted
8366432: Post-merge aarch64 build fixes
Co-authored-by: Bhavana Kilambi <bkilambi@openjdk.org> Reviewed-by: xgong
1 parent 7fdcfe5 commit b09bdb3

File tree

3 files changed

+7
-38
lines changed

3 files changed

+7
-38
lines changed

src/hotspot/cpu/aarch64/aarch64_vector.ad

Lines changed: 3 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -244,6 +244,9 @@ source %{
244244
case Op_MinVHF:
245245
case Op_MaxVHF:
246246
case Op_SqrtVHF:
247+
case Op_AbsVHF:
248+
case Op_NegVHF:
249+
case Op_AddReductionVHF:
247250
// FEAT_FP16 is enabled if both "fphp" and "asimdhp" features are supported.
248251
// Only the Neon instructions need this check. SVE supports half-precision floats
249252
// by default.
@@ -279,20 +282,6 @@ source %{
279282
return false;
280283
}
281284
break;
282-
case Op_AddVHF:
283-
case Op_SubVHF:
284-
case Op_MulVHF:
285-
case Op_DivVHF:
286-
case Op_AbsVHF:
287-
case Op_NegVHF:
288-
case Op_FmaVHF:
289-
case Op_AddReductionVHF:
290-
// FEAT_FP16 is enabled if both "fphp" and "asimdhp" features are supported.
291-
// Only the Neon instructions need this check. SVE supports 16-bit floats by default.
292-
if (UseSVE > 0 || (VM_Version::supports_fphp() && VM_Version::supports_asimdhp())) {
293-
break;
294-
}
295-
return false;
296285
default:
297286
break;
298287
}

src/hotspot/cpu/aarch64/aarch64_vector_ad.m4

Lines changed: 3 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -234,6 +234,9 @@ source %{
234234
case Op_MinVHF:
235235
case Op_MaxVHF:
236236
case Op_SqrtVHF:
237+
case Op_AbsVHF:
238+
case Op_NegVHF:
239+
case Op_AddReductionVHF:
237240
// FEAT_FP16 is enabled if both "fphp" and "asimdhp" features are supported.
238241
// Only the Neon instructions need this check. SVE supports half-precision floats
239242
// by default.
@@ -269,20 +272,6 @@ source %{
269272
return false;
270273
}
271274
break;
272-
case Op_AddVHF:
273-
case Op_SubVHF:
274-
case Op_MulVHF:
275-
case Op_DivVHF:
276-
case Op_AbsVHF:
277-
case Op_NegVHF:
278-
case Op_FmaVHF:
279-
case Op_AddReductionVHF:
280-
// FEAT_FP16 is enabled if both "fphp" and "asimdhp" features are supported.
281-
// Only the Neon instructions need this check. SVE supports 16-bit floats by default.
282-
if (UseSVE > 0 || (VM_Version::supports_fphp() && VM_Version::supports_asimdhp())) {
283-
break;
284-
}
285-
return false;
286275
default:
287276
break;
288277
}

src/hotspot/cpu/aarch64/assembler_aarch64.hpp

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2068,7 +2068,6 @@ void mvnw(Register Rd, Register Rm,
20682068
void data_processing(unsigned op31, unsigned type, unsigned opcode, unsigned op21,
20692069
FloatRegister Vd, FloatRegister Vn, FloatRegister Vm) {
20702070
starti;
2071-
int op21 = (opcode == 0b000101) ? 0b0 : 0b1;
20722071
f(op31, 31, 29);
20732072
f(0b11110, 28, 24);
20742073
f(type, 23, 22), f(op21, 21), f(opcode, 15, 10);
@@ -2129,17 +2128,9 @@ void mvnw(Register Rd, Register Rm,
21292128

21302129
INSN(fabdh, 0b1, 0b1, 0b010); // Floating-point Absolute Difference (half-precision float)
21312130

2132-
INSN(fabdh, 0b011, 0b11, 0b000101);
2133-
INSN(fmulh, 0b000, 0b11, 0b000010);
2134-
INSN(fdivh, 0b000, 0b11, 0b000110);
2135-
INSN(faddh, 0b000, 0b11, 0b001010);
2136-
INSN(fsubh, 0b000, 0b11, 0b001110);
2137-
INSN(fmaxh, 0b000, 0b11, 0b010010);
2138-
INSN(fminh, 0b000, 0b11, 0b010110);
2139-
INSN(fnmulh, 0b000, 0b11, 0b100010);
21402131
#undef INSN
21412132

2142-
// Floating-point data-processing (3 source)
2133+
// Floating-point data-processing (3 source)
21432134
void data_processing(unsigned op31, unsigned type, unsigned o1, unsigned o0,
21442135
FloatRegister Vd, FloatRegister Vn, FloatRegister Vm,
21452136
FloatRegister Va) {

0 commit comments

Comments
 (0)