Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8271009: AArch64: Wrap duplicated SVE instructions into a single method #101

Closed
wants to merge 2 commits into from

Conversation

e1iu
Copy link
Member

@e1iu e1iu commented Jul 23, 2021

This patch is a small cleanup. Since most of the usage of 'sve_whilelo'
are a pair of 'mov' and 'whilelo', this patch wraps them as a single
method.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • JDK-8271009: AArch64: Wrap duplicated SVE instructions into a single method

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/panama-vector pull/101/head:pull/101
$ git checkout pull/101

Update a local copy of the PR:
$ git checkout pull/101
$ git pull https://git.openjdk.java.net/panama-vector pull/101/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 101

View PR using the GUI difftool:
$ git pr show -t 101

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/panama-vector/pull/101.diff

This patch is a small cleanup. Since most of the usage of 'sve_whilelo'
are a pair of 'mov' and 'whilelo', this patch wraps them as a single
method.

Change-Id: I182592c6cfe919eccff7dcc868610f64f270e796
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 23, 2021

👋 Welcome back eliu! A progress list of the required criteria for merging this PR into vectorIntrinsics will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jul 23, 2021
@mlbridge
Copy link

mlbridge bot commented Jul 23, 2021

Webrevs

Change-Id: Iaf1fea93910a9681c8609bcbedfbf8bd4b3291e1
Copy link
Collaborator

@nsjian nsjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

Copy link
Collaborator

@XiaohongGong XiaohongGong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks!

@openjdk
Copy link

openjdk bot commented Jul 26, 2021

@theRealELiu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271009: AArch64: Wrap duplicated SVE instructions into a single method

Reviewed-by: njian, xgong

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the vectorIntrinsics branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@nsjian, @XiaohongGong) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Jul 26, 2021
@e1iu
Copy link
Member Author

e1iu commented Jul 26, 2021

/integrate

@openjdk openjdk bot added the sponsor label Jul 26, 2021
@openjdk
Copy link

openjdk bot commented Jul 26, 2021

@theRealELiu
Your change (at version 4879265) is now ready to be sponsored by a Committer.

@XiaohongGong
Copy link
Collaborator

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 26, 2021

Going to push as commit a0f9d86.

@openjdk
Copy link

openjdk bot commented Jul 26, 2021

@XiaohongGong @theRealELiu Pushed as commit a0f9d86.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@e1iu e1iu deleted the JDK-8271009 branch September 1, 2021 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants