-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8283145: [vector] Add the compiler IR and aarch64 support for count leading and trailing zeros #180
Conversation
…eading and trailing zeros
👋 Welcome back xgong! A progress list of the required criteria for merging this PR into |
Webrevs
|
Thanks for your review @nsjian ! The comments have been addressed. Thanks! |
@XiaohongGong This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Hi @jatin-bhateja , could you please help to take a look at the mid-end part of this patch? Thanks so much! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Common IR changes looks good to me.
Thanks for the review @jatin-bhateja ! |
/integrate |
@XiaohongGong Pushed as commit 03e4da7. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This patch adds the hotspot compiler implementations for the vector operations of count leading and trailing zeros. It adds:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/panama-vector pull/180/head:pull/180
$ git checkout pull/180
Update a local copy of the PR:
$ git checkout pull/180
$ git pull https://git.openjdk.java.net/panama-vector pull/180/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 180
View PR using the GUI difftool:
$ git pr show -t 180
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/panama-vector/pull/180.diff