Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8283145: [vector] Add the compiler IR and aarch64 support for count leading and trailing zeros #180

Closed

Conversation

XiaohongGong
Copy link
Collaborator

@XiaohongGong XiaohongGong commented Mar 17, 2022

This patch adds the hotspot compiler implementations for the vector operations of count leading and trailing zeros. It adds:

  • two vector nodes respectively for the two vector operations
  • the backend implementations for aarch64 NEON and SVE

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • JDK-8283145: [vector] Add the compiler IR and aarch64 support for count leading and trailing zeros

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/panama-vector pull/180/head:pull/180
$ git checkout pull/180

Update a local copy of the PR:
$ git checkout pull/180
$ git pull https://git.openjdk.java.net/panama-vector pull/180/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 180

View PR using the GUI difftool:
$ git pr show -t 180

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/panama-vector/pull/180.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 17, 2022

👋 Welcome back xgong! A progress list of the required criteria for merging this PR into vectorIntrinsics will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Mar 17, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 17, 2022

Webrevs

@XiaohongGong
Copy link
Collaborator Author

Thanks for your review @nsjian ! The comments have been addressed. Thanks!

@openjdk
Copy link

openjdk bot commented Mar 21, 2022

@XiaohongGong This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283145: [vector] Add the compiler IR and aarch64 support for count leading and trailing zeros

Reviewed-by: njian, jbhateja

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the vectorIntrinsics branch:

  • 701e6ba: 8282942: [vector] Trivial code style updates

Please see this link for an up-to-date comparison between the source branch of this pull request and the vectorIntrinsics branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the vectorIntrinsics branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 21, 2022
@XiaohongGong
Copy link
Collaborator Author

Hi @jatin-bhateja , could you please help to take a look at the mid-end part of this patch? Thanks so much!

Copy link
Member

@jatin-bhateja jatin-bhateja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Common IR changes looks good to me.

@XiaohongGong
Copy link
Collaborator Author

Thanks for the review @jatin-bhateja !

@XiaohongGong
Copy link
Collaborator Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 22, 2022

Going to push as commit 03e4da7.
Since your change was applied there has been 1 commit pushed to the vectorIntrinsics branch:

  • 701e6ba: 8282942: [vector] Trivial code style updates

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Mar 22, 2022
@openjdk openjdk bot closed this Mar 22, 2022
@openjdk
Copy link

openjdk bot commented Mar 22, 2022

@XiaohongGong Pushed as commit 03e4da7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@XiaohongGong XiaohongGong deleted the JDK-8283145 branch March 22, 2022 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants