8343779: Cannot build Vector API JMH benchmarks on vectorIntrinsics branch #221
Conversation
…ranch To generate pseudo-random values, the benchmarks mostly reference the Random RAND object. However, occasionally RANDOM is referenced instead of RAND. The mismatch causes build errors. Reference RAND across Vector API JMH benchmarks consistently.
|
👋 Welcome back mikabl-arm! A progress list of the required criteria for merging this PR into |
|
@mikabl-arm This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@PaulSandoz) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
Webrevs
|
|
Thank you for looking at this. This area has obviously bit rotted. Many of these classes are generated from templates. You need to modify the templates and run the generation script instead of modifying directly. See https://github.com/openjdk/panama-vector/blob/vectorIntrinsics/test/jdk/jdk/incubator/vector/README.md See https://github.com/openjdk/panama-vector/tree/vectorIntrinsics/test/jdk/jdk/incubator/vector/templates for the perf-related templates (specifically Perf-Scalar-header.template and Perf-header.template). Other non-template generated benchmarks also require updating due to additional compiler warnings (which are configured to be errors), specifically about lossy numerical conversion. (See VectorDistance.java, ChaChaBench.java, and Poly1305Bench.java) |
Some benchmarks fail to build due to lossy-conversion compiler warnings which are configured to be errors. Fix narrowing numerical conversions.
|
/integrate |
|
@mikabl-arm |
|
/sponsor |
|
Going to push as commit 6c94580. |
|
@PaulSandoz @mikabl-arm Pushed as commit 6c94580. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
To generate pseudo-random values, the benchmarks mostly reference the
Random RAND object. However, occasionally RANDOM is referenced instead
of RAND. The mismatch causes build errors. Reference RAND across Vector
API JMH benchmarks consistently.
Some benchmarks fail to build due to lossy-conversion compiler warnings
which are configured to be errors. Fix narrowing numerical conversions.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/panama-vector.git pull/221/head:pull/221$ git checkout pull/221Update a local copy of the PR:
$ git checkout pull/221$ git pull https://git.openjdk.org/panama-vector.git pull/221/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 221View PR using the GUI difftool:
$ git pr show -t 221Using diff file
Download this PR as a diff file:
https://git.openjdk.org/panama-vector/pull/221.diff
Using Webrev
Link to Webrev Comment