-
Notifications
You must be signed in to change notification settings - Fork 43
8253211: Make sure jvm does not crash with Arm SVE and Vector API #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add those vector api specific OPs to unsupported list for SVE.
👋 Welcome back njian! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@nsjian This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements After integration, the commit message will be:
There are currently no new commits on the ➡️ To integrate this PR with the above commit message to the |
Can you please rebase to the |
Mailing list message from Vladimir Ivanov on panama-dev:
Good point! I completely missed that the PR is against vector-unstable :-) Best regards, |
Without this patch, jvm will crash on SVE with Vector API, so I want to get this into 'vector-unstable' for integration into jdk. Do you think it make sense? Current vectorIntrinsics is a bit behind vector-unstable and jdk/jdk, e.g. without Arm SVE support yet, so this patch cannot apply to vectorIntrinsics. We need to merge vector-unstable into vectorIntrinsics first. |
@nsjian Is it possible for you to send a pull request to merge master with I don't want to add anything to |
Sure, I will give a try.
OK, that's fine to me. |
Add those vector api specific OPs to unsupported list for SVE.
Currently we have not implemented all Arm SVE code generation for
Vector API specific nodes. To make sure hotspot does not crash with bad
AD file (as NEON has implemented them), we simply add those OPs to
unsupported op list.
This patch also fixed one missing VectorA handling in previous merge.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/panama-vector pull/3/head:pull/3
$ git checkout pull/3