Skip to content

8253211: Make sure jvm does not crash with Arm SVE and Vector API #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

nsjian
Copy link

@nsjian nsjian commented Sep 16, 2020

Add those vector api specific OPs to unsupported list for SVE.

Currently we have not implemented all Arm SVE code generation for
Vector API specific nodes. To make sure hotspot does not crash with bad
AD file (as NEON has implemented them), we simply add those OPs to
unsupported op list.

This patch also fixed one missing VectorA handling in previous merge.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253211: Make sure jvm does not crash with Arm SVE and Vector API

Reviewers

Download

$ git fetch https://git.openjdk.java.net/panama-vector pull/3/head:pull/3
$ git checkout pull/3

Add those vector api specific OPs to unsupported list for SVE.
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 16, 2020

👋 Welcome back njian! A progress list of the required criteria for merging this PR into vector-unstable will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 16, 2020
@mlbridge
Copy link

mlbridge bot commented Sep 16, 2020

Webrevs

Copy link
Collaborator

@iwanowww iwanowww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Sep 16, 2020

@nsjian This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8253211: Make sure jvm does not crash with Arm SVE and Vector API

Reviewed-by: vlivanov
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the vector-unstable branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate 95cd392cf34469db4d5dbc8fbca28008797225cf.

➡️ To integrate this PR with the above commit message to the vector-unstable branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 16, 2020
@PaulSandoz
Copy link
Member

Can you please rebase to the vectorIntrinsics branch? We are trying to keep vector-unstable stable :-) for integration into jdk. After that we can then take changes to vectorIntrinsics directly to jdk.

@mlbridge
Copy link

mlbridge bot commented Sep 16, 2020

Mailing list message from Vladimir Ivanov on panama-dev:

Can you please rebase to the `vectorIntrinsics` branch? We are trying to keep `vector-unstable` stable :-) for
integration into `jdk`. After that we can then take changes to `vectorIntrinsics` directly to `jdk`.

Good point! I completely missed that the PR is against vector-unstable :-)

Best regards,
Vladimir Ivanov

@nsjian
Copy link
Author

nsjian commented Sep 17, 2020

Can you please rebase to the vectorIntrinsics branch? We are trying to keep vector-unstable stable :-) for integration into jdk. After that we can then take changes to vectorIntrinsics directly to jdk.

Without this patch, jvm will crash on SVE with Vector API, so I want to get this into 'vector-unstable' for integration into jdk. Do you think it make sense? Current vectorIntrinsics is a bit behind vector-unstable and jdk/jdk, e.g. without Arm SVE support yet, so this patch cannot apply to vectorIntrinsics. We need to merge vector-unstable into vectorIntrinsics first.

@PaulSandoz
Copy link
Member

@nsjian Is it possible for you to send a pull request to merge master with vectorIntrinsics, and then a second pull request for this to vectorIntrinsics?

I don't want to add anything to vector-unstable, except merge updates, that might cause a re-review of code. When i send the pull request for integration i want to state accurately that the code was already reviewed (if we were still using mercurial we could just push directly). It should be possible to quickly follow up after the initial integration.

@nsjian
Copy link
Author

nsjian commented Sep 17, 2020

@nsjian Is it possible for you to send a pull request to merge master with vectorIntrinsics, and then a second pull request for this to vectorIntrinsics?

Sure, I will give a try.

I don't want to add anything to vector-unstable, except merge updates, that might cause a re-review of code. When i send the pull request for integration i want to state accurately that the code was already reviewed (if we were still using mercurial we could just push directly). It should be possible to quickly follow up after the initial integration.

OK, that's fine to me.

@nsjian nsjian closed this Sep 17, 2020
openjdk bot pushed a commit that referenced this pull request Sep 24, 2024
Reviewed-by: honkar, prr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants