Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8259536: Add cast nodes between interger types implementation for Arm SVE #31

Closed

Conversation

@Wanghuang-Huawei
Copy link
Collaborator

@Wanghuang-Huawei Wanghuang-Huawei commented Jan 12, 2021

This patch add cast nodes between interger types implementation for Arm SVE like "VectorCastB2X" "VectorCastI2X " "VectorCastS2X" "VectorCastL2X".


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • JDK-8259536: Add cast nodes between interger types implementation for Arm SVE

Reviewers

Download

$ git fetch https://git.openjdk.java.net/panama-vector pull/31/head:pull/31
$ git checkout pull/31

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 12, 2021

👋 Welcome back whuang! A progress list of the required criteria for merging this PR into vectorIntrinsics will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Jan 12, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 12, 2021

Loading

src/hotspot/share/opto/vectorIntrinsics.cpp Outdated Show resolved Hide resolved
Loading
@XiaohongGong
Copy link
Collaborator

@XiaohongGong XiaohongGong commented Jan 18, 2021

Hi @Wanghuang-Huawei, thanks for adding the SVE support for VectorCast. I observed that this patch misses some type casts like: byte -> long, short -> long, long -> byte and long -> short. Do you have any plan to add these missing parts in future? I'd suggest to add them all with the single patch. WDYT?

Loading

@Wanghuang-Huawei
Copy link
Collaborator Author

@Wanghuang-Huawei Wanghuang-Huawei commented Jan 26, 2021

Hi @Wanghuang-Huawei, thanks for adding the SVE support for VectorCast. I observed that this patch misses some type casts like: byte -> long, short -> long, long -> byte and long -> short. Do you have any plan to add these missing parts in future? I'd suggest to add them all with the single patch. WDYT?

OK. I will add them in next commit.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jan 26, 2021

@Wanghuang-Huawei this pull request can not be integrated into vectorIntrinsics due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout JDK-8259536
git fetch https://git.openjdk.java.net/panama-vector vectorIntrinsics
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge vectorIntrinsics"
git push

Loading

Copy link
Collaborator

@nsjian nsjian left a comment

@Wanghuang-Huawei Thanks a lot for the work! Could you please do a merge and resolve the merge conflicts?

Loading

src/hotspot/cpu/aarch64/aarch64_sve.ad Show resolved Hide resolved
Loading
src/hotspot/share/opto/vectorIntrinsics.cpp Outdated Show resolved Hide resolved
Loading
src/hotspot/share/opto/vectorIntrinsics.cpp Outdated Show resolved Hide resolved
Loading
@openjdk openjdk bot removed the merge-conflict label Jan 28, 2021
Copy link
Collaborator Author

@Wanghuang-Huawei Wanghuang-Huawei left a comment

@Wanghuang-Huawei Thanks a lot for the work! Could you please do a merge and resolve the merge conflicts?

OK. I have resolved that.

Loading

src/hotspot/share/opto/vectorIntrinsics.cpp Outdated Show resolved Hide resolved
Loading
src/hotspot/cpu/aarch64/aarch64_sve_ad.m4 Outdated Show resolved Hide resolved
Loading
src/hotspot/cpu/aarch64/aarch64_sve_ad.m4 Show resolved Hide resolved
Loading
src/hotspot/cpu/aarch64/aarch64_sve_ad.m4 Outdated Show resolved Hide resolved
Loading
src/hotspot/cpu/aarch64/aarch64_sve_ad.m4 Outdated Show resolved Hide resolved
Loading
src/hotspot/cpu/aarch64/aarch64_sve_ad.m4 Outdated Show resolved Hide resolved
Loading
nsjian
nsjian approved these changes Feb 2, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 2, 2021

@Wanghuang-Huawei This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259536: Add cast nodes between interger types implementation for Arm SVE

Reviewed-by: njian, xgong

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the vectorIntrinsics branch:

  • 6381e8d: 8260668: vectorIntrinsics windows build problem

Please see this link for an up-to-date comparison between the source branch of this pull request and the vectorIntrinsics branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@nsjian) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

Loading

@openjdk openjdk bot added the ready label Feb 2, 2021
@Wanghuang-Huawei
Copy link
Collaborator Author

@Wanghuang-Huawei Wanghuang-Huawei commented Feb 3, 2021

/integrate

Loading

@openjdk openjdk bot added the sponsor label Feb 3, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 3, 2021

@Wanghuang-Huawei
Your change (at version 177bdab) is now ready to be sponsored by a Committer.

Loading

@nsjian
Copy link
Collaborator

@nsjian nsjian commented Feb 3, 2021

/sponsor

Loading

@openjdk openjdk bot closed this Feb 3, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 3, 2021

@nsjian @Wanghuang-Huawei Since your change was applied there has been 1 commit pushed to the vectorIntrinsics branch:

  • 6381e8d: 8260668: vectorIntrinsics windows build problem

Your commit was automatically rebased without conflicts.

Pushed as commit f53ee78.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants