Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261267: Math vector stubs are not called from jitted code #35

Closed
wants to merge 1 commit into from

Conversation

@sviswa7
Copy link
Collaborator

@sviswa7 sviswa7 commented Feb 5, 2021

The svml math vector stubs intrinsification is failing and the stubs are not being called from jitted code.
The LibraryCallKit::inline_vector_nary_operation needs to be updated to call the svml math vector stubs where available.
Also the MachCallRuntimeNode::ret_addr_offset() in the ad file needs to be adjusted for vector calls.

Please review.

Best Regards,
Sandhya


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • JDK-8261267: Math vector stubs are not called from jitted code

Reviewers

Download

$ git fetch https://git.openjdk.java.net/panama-vector pull/35/head:pull/35
$ git checkout pull/35

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 5, 2021

👋 Welcome back sviswanathan! A progress list of the required criteria for merging this PR into vectorIntrinsics will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@sviswa7 sviswa7 marked this pull request as ready for review Feb 5, 2021
@openjdk openjdk bot added the rfr label Feb 5, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 5, 2021

Webrevs

Loading

Copy link
Collaborator

@iwanowww iwanowww left a comment

Looks good.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Feb 8, 2021

@sviswa7 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261267: Math vector stubs are not called from jitted code

Reviewed-by: vlivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the vectorIntrinsics branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the vectorIntrinsics branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Feb 8, 2021
@sviswa7
Copy link
Collaborator Author

@sviswa7 sviswa7 commented Feb 8, 2021

Thanks a lot @iwanowww for the review.

Loading

@sviswa7
Copy link
Collaborator Author

@sviswa7 sviswa7 commented Feb 8, 2021

/integrate

Loading

@openjdk openjdk bot closed this Feb 8, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 8, 2021

@sviswa7 Pushed as commit 3e06fc0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants