Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8263001: Add cast nodes from single precision float types to interger types implementation for Arm SVE #46

Conversation

@Wanghuang-Huawei
Copy link
Collaborator

@Wanghuang-Huawei Wanghuang-Huawei commented Mar 9, 2021

  • add sve_fcvtzs & sve_fcvtzu
  • add F2I F2S F2B F2L
  • change macro name VECTOR_CAST_I2F -> VECTOR_CAST_X2X becase we reuse it.

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • JDK-8263001: Add cast nodes from single precision float types to interger types implementation for Arm SVE

Reviewers

Contributors

  • Wang Huang <whuang@openjdk.org>
  • Ai Jiaming <aijiaming1@huawei.com>
  • He Xuejin <hexuejin2@huawei.com>

Download

$ git fetch https://git.openjdk.java.net/panama-vector pull/46/head:pull/46
$ git checkout pull/46

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 9, 2021

👋 Welcome back whuang! A progress list of the required criteria for merging this PR into vectorIntrinsics will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Mar 9, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 9, 2021

Webrevs

Loading

@Wanghuang-Huawei
Copy link
Collaborator Author

@Wanghuang-Huawei Wanghuang-Huawei commented Mar 9, 2021

/contributor add Wang Huang whuang@openjdk.org
/contributor add Ai Jiaming aijiaming1@huawei.com
/contributor add He Xuejin hexuejin2@huawei.com

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Mar 9, 2021

@Wanghuang-Huawei
Contributor Wang Huang <whuang@openjdk.org> successfully added.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Mar 9, 2021

@Wanghuang-Huawei
Contributor Ai Jiaming <aijiaming1@huawei.com> successfully added.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Mar 9, 2021

@Wanghuang-Huawei
Contributor He Xuejin <hexuejin2@huawei.com> successfully added.

Loading

@Wanghuang-Huawei Wanghuang-Huawei changed the title Add cast nodes from single precision float types to interger types implementation for Arm SVE 8263001: Add cast nodes from single precision float types to interger types implementation for Arm SVE Mar 9, 2021
nsjian
nsjian approved these changes Mar 9, 2021
Copy link
Collaborator

@nsjian nsjian left a comment

Looks good. Thanks!

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Mar 9, 2021

@Wanghuang-Huawei This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263001: Add cast nodes from single precision float types to interger types implementation for Arm SVE

Co-authored-by: Wang Huang <whuang@openjdk.org>
Co-authored-by: Ai Jiaming <aijiaming1@huawei.com>
Co-authored-by: He Xuejin <hexuejin2@huawei.com>
Reviewed-by: njian

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the vectorIntrinsics branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@nsjian) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

Loading

@openjdk openjdk bot added the ready label Mar 9, 2021
@Wanghuang-Huawei
Copy link
Collaborator Author

@Wanghuang-Huawei Wanghuang-Huawei commented Mar 9, 2021

/integrate

Loading

@openjdk openjdk bot added the sponsor label Mar 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 9, 2021

@Wanghuang-Huawei
Your change (at version ec66424) is now ready to be sponsored by a Committer.

Loading

@nsjian
Copy link
Collaborator

@nsjian nsjian commented Mar 10, 2021

/sponsor

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Mar 10, 2021

@nsjian @Wanghuang-Huawei Pushed as commit 78176f7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants