Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8263417: Add Extract integer nodes implementation for Arm SVE #48

Closed

Conversation

Wanghuang-Huawei
Copy link
Collaborator

@Wanghuang-Huawei Wanghuang-Huawei commented Mar 12, 2021

  • Add Extract integer nodes implementation for Arm SVE, like ExtractB/ExtractS/ExtractI/ExtractL
  • add sve_lasta(Register, SIMD_RegVariant, PRegister, FloatRegister) & sve_lastb

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • JDK-8263417: Add Extract integer nodes implementation for Arm SVE

Reviewers

Contributors

  • Wang Huang <whuang@openjdk.org>
  • He Xuejin <hexuejin2@huawei.com>
  • Ai Jiaming <aijiaming1@huawei.com>

Download

$ git fetch https://git.openjdk.java.net/panama-vector pull/48/head:pull/48
$ git checkout pull/48

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 12, 2021

👋 Welcome back whuang! A progress list of the required criteria for merging this PR into vectorIntrinsics will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Mar 12, 2021
@Wanghuang-Huawei
Copy link
Collaborator Author

/contributor add Wang Huang whuang@openjdk.org
/contributor add He Xuejin hexuejin2@huawei.com
/contributor add Ai Jiaming aijiaming1@huawei.com

@openjdk
Copy link

openjdk bot commented Mar 12, 2021

@Wanghuang-Huawei
Contributor Wang Huang <whuang@openjdk.org> successfully added.

@openjdk
Copy link

openjdk bot commented Mar 12, 2021

@Wanghuang-Huawei
Contributor He Xuejin <hexuejin2@huawei.com> successfully added.

@openjdk
Copy link

openjdk bot commented Mar 12, 2021

@Wanghuang-Huawei
Contributor Ai Jiaming <aijiaming1@huawei.com> successfully added.

@Wanghuang-Huawei Wanghuang-Huawei changed the title Add Extract integer nodes implementation for Arm SVE 8263417: Add Extract integer nodes implementation for Arm SVE Mar 12, 2021
@mlbridge
Copy link

mlbridge bot commented Mar 12, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 16, 2021

@Wanghuang-Huawei This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263417: Add Extract integer nodes implementation for Arm SVE

Co-authored-by: Wang Huang <whuang@openjdk.org>
Co-authored-by: He Xuejin <hexuejin2@huawei.com>
Co-authored-by: Ai Jiaming <aijiaming1@huawei.com>
Reviewed-by: njian

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the vectorIntrinsics branch:

  • 5165981: 8263149: Adding benchmarks for Vector API

Please see this link for an up-to-date comparison between the source branch of this pull request and the vectorIntrinsics branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@nsjian) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Mar 16, 2021
@Wanghuang-Huawei
Copy link
Collaborator Author

/integrate

@openjdk openjdk bot added the sponsor label Mar 16, 2021
@openjdk
Copy link

openjdk bot commented Mar 16, 2021

@Wanghuang-Huawei
Your change (at version c3c9f87) is now ready to be sponsored by a Committer.

@nsjian
Copy link

nsjian commented Mar 16, 2021

/sponsor

@openjdk openjdk bot closed this Mar 16, 2021
@openjdk
Copy link

openjdk bot commented Mar 16, 2021

@nsjian @Wanghuang-Huawei Since your change was applied there has been 1 commit pushed to the vectorIntrinsics branch:

  • 5165981: 8263149: Adding benchmarks for Vector API

Your commit was automatically rebased without conflicts.

Pushed as commit 864a62c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr label Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants