Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8263644: Add Extract float nodes implementation for Arm SVE #51

Closed

Conversation

Wanghuang-Huawei
Copy link
Collaborator

@Wanghuang-Huawei Wanghuang-Huawei commented Mar 17, 2021

We implement ExtractD & ExtractF Node for Arm SVE backend.

  • overload encoding functions sve_lasta & sve_lastb
  • for future JDK-8263424, we eliminate vector length judgements and use rscratch1

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • JDK-8263644: Add Extract float nodes implementation for Arm SVE

Reviewers

Contributors

  • Wang Huang <whuang@openjdk.org>
  • He Xuejin <hexuejin2@huawei.com>
  • Ai Jiaming <aijiaming1@huawei.com>

Download

To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/panama-vector pull/51/head:pull/51
$ git checkout pull/51

To update a local copy of the PR:
$ git checkout pull/51
$ git pull https://git.openjdk.java.net/panama-vector pull/51/head

@Wanghuang-Huawei
Copy link
Collaborator Author

@Wanghuang-Huawei Wanghuang-Huawei commented Mar 17, 2021

/contributor add Wang Huang whuang@openjdk.org
/contributor add He Xuejin hexuejin2@huawei.com
/contributor add Ai Jiaming aijiaming1@huawei.com

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 17, 2021

👋 Welcome back whuang! A progress list of the required criteria for merging this PR into vectorIntrinsics will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Mar 17, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 17, 2021

@Wanghuang-Huawei Could not parse Wang Huang whuang@openjdk.org as a valid contributor.
Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

  • /contributor add @openjdk-bot
  • /contributor add duke
  • /contributor add J. Duke <duke@openjdk.org>

@openjdk
Copy link

@openjdk openjdk bot commented Mar 17, 2021

@Wanghuang-Huawei Could not parse He Xuejin hexuejin2@huawei.com as a valid contributor.
Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

  • /contributor add @openjdk-bot
  • /contributor add duke
  • /contributor add J. Duke <duke@openjdk.org>

@openjdk
Copy link

@openjdk openjdk bot commented Mar 17, 2021

@Wanghuang-Huawei Could not parse Ai Jiaming aijiaming1@huawei.com as a valid contributor.
Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

  • /contributor add @openjdk-bot
  • /contributor add duke
  • /contributor add J. Duke <duke@openjdk.org>

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 17, 2021

Webrevs

@Wanghuang-Huawei
Copy link
Collaborator Author

@Wanghuang-Huawei Wanghuang-Huawei commented Mar 18, 2021

/contributor add Wang Huang whuang@openjdk.org
/contributor add He Xuejin hexuejin2@huawei.com
/contributor add Ai Jiaming aijiaming1@huawei.com

@openjdk
Copy link

@openjdk openjdk bot commented Mar 18, 2021

@Wanghuang-Huawei
Contributor Wang Huang <whuang@openjdk.org> successfully added.

@openjdk
Copy link

@openjdk openjdk bot commented Mar 18, 2021

@Wanghuang-Huawei
Contributor He Xuejin <hexuejin2@huawei.com> successfully added.

@openjdk
Copy link

@openjdk openjdk bot commented Mar 18, 2021

@Wanghuang-Huawei
Contributor Ai Jiaming <aijiaming1@huawei.com> successfully added.

@XiaohongGong
Copy link
Collaborator

@XiaohongGong XiaohongGong commented Mar 22, 2021

LGTM, thanks!

@openjdk
Copy link

@openjdk openjdk bot commented Mar 23, 2021

@Wanghuang-Huawei This PR has not yet been marked as ready for integration.

nsjian
nsjian approved these changes Mar 23, 2021
Copy link
Collaborator

@nsjian nsjian left a comment

Looks good. Thanks!

@openjdk
Copy link

@openjdk openjdk bot commented Mar 23, 2021

@Wanghuang-Huawei This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263644: Add Extract float nodes implementation for Arm SVE

Co-authored-by: Wang Huang <whuang@openjdk.org>
Co-authored-by: He Xuejin <hexuejin2@huawei.com>
Co-authored-by: Ai Jiaming <aijiaming1@huawei.com>
Reviewed-by: xgong, njian

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the vectorIntrinsics branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@nsjian) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Mar 23, 2021
@Wanghuang-Huawei
Copy link
Collaborator Author

@Wanghuang-Huawei Wanghuang-Huawei commented Mar 23, 2021

/integrate

@openjdk openjdk bot added the sponsor label Mar 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 23, 2021

@Wanghuang-Huawei
Your change (at version 630a267) is now ready to be sponsored by a Committer.

@nsjian
Copy link
Collaborator

@nsjian nsjian commented Mar 23, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Mar 23, 2021

@nsjian @Wanghuang-Huawei Pushed as commit 47334c5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants