Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264153: Add Insert integer nodes implementation for Arm SVE #54

Closed

Conversation

Wanghuang-Huawei
Copy link
Collaborator

@Wanghuang-Huawei Wanghuang-Huawei commented Mar 29, 2021

Add Insert integer nodes implementation for Arm SVE, such like VectorInsert(B/S/I/L) Node.

  • add sve_index & sve_cpy

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • JDK-8264153: Add Insert integer nodes implementation for Arm SVE

Reviewers

Contributors

  • Wang Huang <whuang@openjdk.org>
  • Ai Jiaming <aijiaming1@huawei.com>
  • He Xuejin <hexuejin2@huawei.com>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/panama-vector pull/54/head:pull/54
$ git checkout pull/54

Update a local copy of the PR:
$ git checkout pull/54
$ git pull https://git.openjdk.java.net/panama-vector pull/54/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 54

View PR using the GUI difftool:
$ git pr show -t 54

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/panama-vector/pull/54.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 29, 2021

👋 Welcome back whuang! A progress list of the required criteria for merging this PR into vectorIntrinsics will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Mar 29, 2021
@Wanghuang-Huawei
Copy link
Collaborator Author

Wanghuang-Huawei commented Mar 29, 2021

/contributor add Wang Huang whuang@openjdk.org
/contributor add Ai Jiaming aijiaming1@huawei.com
/contributor add He Xuejin hexuejin2@huawei.com

@openjdk
Copy link

openjdk bot commented Mar 29, 2021

@Wanghuang-Huawei
Contributor Wang Huang <whuang@openjdk.org> successfully added.

@openjdk
Copy link

openjdk bot commented Mar 29, 2021

@Wanghuang-Huawei
Contributor Ai Jiaming <aijiaming1@huawei.com> successfully added.

@openjdk
Copy link

openjdk bot commented Mar 29, 2021

@Wanghuang-Huawei
Contributor He Xuejin <hexuejin2@huawei.com> successfully added.

@mlbridge
Copy link

mlbridge bot commented Mar 29, 2021

Webrevs

src/hotspot/cpu/aarch64/aarch64_sve_ad.m4 Outdated Show resolved Hide resolved
src/hotspot/cpu/aarch64/assembler_aarch64.hpp Outdated Show resolved Hide resolved
src/hotspot/cpu/aarch64/assembler_aarch64.hpp Outdated Show resolved Hide resolved
src/hotspot/cpu/aarch64/aarch64_sve_ad.m4 Outdated Show resolved Hide resolved
nsjian
nsjian approved these changes Mar 30, 2021
Copy link
Collaborator

@nsjian nsjian left a comment

Looks good to me. Thanks for the work!

@openjdk
Copy link

openjdk bot commented Mar 30, 2021

@Wanghuang-Huawei This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264153: Add Insert integer nodes implementation for Arm SVE

Co-authored-by: Wang Huang <whuang@openjdk.org>
Co-authored-by: Ai Jiaming <aijiaming1@huawei.com>
Co-authored-by: He Xuejin <hexuejin2@huawei.com>
Reviewed-by: njian

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the vectorIntrinsics branch:

  • dc12612: 8264321: Create a separate library for x86 Intel SVML assembly intrinsics

Please see this link for an up-to-date comparison between the source branch of this pull request and the vectorIntrinsics branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@nsjian) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Mar 30, 2021
@Wanghuang-Huawei
Copy link
Collaborator Author

Wanghuang-Huawei commented Mar 30, 2021

/integrate

@openjdk openjdk bot added the sponsor label Mar 30, 2021
@openjdk
Copy link

openjdk bot commented Mar 30, 2021

@Wanghuang-Huawei
Your change (at version ecdfa51) is now ready to be sponsored by a Committer.

@nsjian
Copy link
Collaborator

nsjian commented Mar 30, 2021

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 30, 2021

@nsjian @Wanghuang-Huawei Since your change was applied there has been 1 commit pushed to the vectorIntrinsics branch:

  • dc12612: 8264321: Create a separate library for x86 Intel SVML assembly intrinsics

Your commit was automatically rebased without conflicts.

Pushed as commit 84bc837.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants