New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8264153: Add Insert integer nodes implementation for Arm SVE #54
8264153: Add Insert integer nodes implementation for Arm SVE #54
Conversation
👋 Welcome back whuang! A progress list of the required criteria for merging this PR into |
/contributor add Wang Huang whuang@openjdk.org |
@Wanghuang-Huawei |
@Wanghuang-Huawei |
@Wanghuang-Huawei |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for the work!
@Wanghuang-Huawei This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@nsjian) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@Wanghuang-Huawei |
/sponsor |
@nsjian @Wanghuang-Huawei Since your change was applied there has been 1 commit pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 84bc837. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Add Insert integer nodes implementation for Arm SVE, such like VectorInsert(B/S/I/L) Node.
sve_index
&sve_cpy
Progress
Issue
Reviewers
Contributors
<whuang@openjdk.org>
<aijiaming1@huawei.com>
<hexuejin2@huawei.com>
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/panama-vector pull/54/head:pull/54
$ git checkout pull/54
Update a local copy of the PR:
$ git checkout pull/54
$ git pull https://git.openjdk.java.net/panama-vector pull/54/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 54
View PR using the GUI difftool:
$ git pr show -t 54
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/panama-vector/pull/54.diff