Skip to content

8253211: Make sure jvm does not crash with Arm SVE and Vector API #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

8253211: Make sure jvm does not crash with Arm SVE and Vector API #7

wants to merge 1 commit into from

Conversation

nsjian
Copy link

@nsjian nsjian commented Sep 21, 2020 •
edited by openjdk bot
Loading

Add those vector api specific OPs to unsupported list for SVE.

This is a rebase of #3 to vectorIntrinsics.

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • JDK-8253211: Make sure jvm does not crash with Arm SVE and Vector API

Reviewers

Download

$ git fetch https://git.openjdk.java.net/panama-vector pull/7/head:pull/7
$ git checkout pull/7

8253211: Make sure jvm does not crash with Arm SVE and Vector API
2f5dcd4 
Add those vector api specific OPs to unsupported list for SVE.
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 21, 2020

👋 Welcome back njian! A progress list of the required criteria for merging this PR into vectorIntrinsics will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 21, 2020
@mlbridge
Copy link

mlbridge bot commented Sep 21, 2020

Webrevs

iwanowww
iwanowww approved these changes Sep 21, 2020
View reviewed changes
Copy link
Collaborator

@iwanowww iwanowww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Sep 21, 2020

@nsjian This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8253211: Make sure jvm does not crash with Arm SVE and Vector API

Reviewed-by: vlivanov
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the vectorIntrinsics branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate 925350ff4d41bdc2fab90f0a3e0bf74e9ed36c54.

➡️ To integrate this PR with the above commit message to the vectorIntrinsics branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 21, 2020
@nsjian
Copy link
Author

nsjian commented Sep 22, 2020

/integrate

@openjdk openjdk bot closed this Sep 22, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 22, 2020
@openjdk
Copy link

openjdk bot commented Sep 22, 2020

@nsjian Pushed as commit e27a878.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@nsjian nsjian deleted the JDK-8253211 branch September 25, 2020 02:33
@nsjian nsjian mentioned this pull request Oct 16, 2020
Closed
2 tasks
nsjian pushed a commit to nsjian/jdk that referenced this pull request Oct 19, 2020
8254884: Make sure jvm does not crash with Arm SVE and Vector API
1e51f41 
===
Currently we have not implemented all Arm SVE code generation for
Vector API specific nodes. To make sure hotspot does not crash with bad
AD file (as NEON has implemented them), we simply add those OPs to
unsupported op list.

This is the port and minor cleanup of JDK-8253211 in repo-panama:
openjdk/panama-vector#7
with Op_VectorUnbox (not for codegen) and Op_VectorMaskWrapper (unused
code?) removed from the unsupported op list and Op_VectorLoadConst
added.

Test: tier1-3 on AArch64 and x86_64 as well as Vector API tests on
AArch64 SVE.
@nsjian nsjian mentioned this pull request Oct 19, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwanowww iwanowww iwanowww approved these changes

Assignees
No one assigned
Labels
integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nsjian @iwanowww