8266775: Add VectorLoadConst node implementation for Arm SVE #79

Wanghuang-Huawei · 2021-05-08T08:49:34Z

add VectorLoadConst node implementation for Arm SVE by
- ~~add new data in generate_iota_indices~~
- ~~sve_ld1b these data~~
- sve_index

Thank you for your review. Any suggestion is welcome.

Progress

Change must not contain extraneous whitespace
Change must be properly reviewed

Issue

JDK-8266775: Add VectorLoadConst node implementation for Arm SVE

Reviewers

Xiaohong Gong (@XiaohongGong - Committer)
Ningsheng Jian (@nsjian - Committer)

Contributors

Wang Huang <whuang@openjdk.org>
Ai Jiaming <aijiaming1@huawei.com>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/panama-vector pull/79/head:pull/79
$ git checkout pull/79

Update a local copy of the PR:
$ git checkout pull/79
$ git pull https://git.openjdk.java.net/panama-vector pull/79/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 79

View PR using the GUI difftool:
$ git pr show -t 79

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/panama-vector/pull/79.diff

Wanghuang-Huawei · 2021-05-08T08:50:32Z

/contributor add Wang Huang whuang@openjdk.org
/contributor add Ai Jiaming aijiaming1@huawei.com

bridgekeeper · 2021-05-08T08:50:48Z

👋 Welcome back whuang! A progress list of the required criteria for merging this PR into vectorIntrinsics will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2021-05-08T08:52:36Z

@Wanghuang-Huawei
Contributor Wang Huang <whuang@openjdk.org> successfully added.

openjdk · 2021-05-08T08:55:10Z

@Wanghuang-Huawei
Contributor Ai Jiaming <aijiaming1@huawei.com> successfully added.

mlbridge · 2021-05-08T09:00:20Z

Webrevs

XiaohongGong · 2021-05-10T09:55:43Z

src/hotspot/cpu/aarch64/aarch64_sve.ad

+    __ lea(rscratch1, ExternalAddress(StubRoutines::aarch64::vector_iota_indices()));
+    __ sve_ld1b(as_FloatRegister($dst$$reg), __ B, ptrue, Address(rscratch1, 0));


Could it use INDEX <Zd>.<T>, #<imm1>, #<imm2> (Create index starting from and incremented by immediate) here?

Great suggestion. I will change that. Thank you.

nsjian · 2021-05-12T05:59:40Z

src/hotspot/cpu/aarch64/aarch64_sve_ad.m4

+// ------------------------------ Vector Load Const -------------------------------
+instruct loadconB(vReg dst, immI0 src)


Add a blank line between them?

nsjian · 2021-05-12T06:01:44Z

src/hotspot/cpu/aarch64/aarch64_sve_ad.m4

+  predicate(UseSVE > 0 &&
+            n->bottom_type()->is_vect()->element_basic_type() == T_BYTE);


When the size is 16, the neon pattern will also be matched. Can you please add "UseSVE == 0" for NEON VectorLoadConst patterns?

Thank you for your review. I have changed that.

openjdk · 2021-05-14T03:14:39Z

@Wanghuang-Huawei This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266775: Add VectorLoadConst node implementation for Arm SVE

Co-authored-by: Wang Huang <whuang@openjdk.org>
Co-authored-by: Ai Jiaming <aijiaming1@huawei.com>
Reviewed-by: xgong, njian

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the vectorIntrinsics branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the vectorIntrinsics branch, type /integrate in a new comment.

XiaohongGong · 2021-05-14T03:15:18Z

Looks good to me! I think it's better to also get approved by @nsjian . Thanks!

nsjian

Looks good to me. Thanks!

Wanghuang-Huawei · 2021-05-17T06:24:27Z

/sponsor

Wanghuang-Huawei · 2021-05-17T06:25:06Z

/integrate

openjdk · 2021-05-17T06:25:09Z

@Wanghuang-Huawei This change does not need sponsoring - the author is allowed to integrate it.

Wanghuang-Huawei · 2021-05-17T06:26:10Z

/sponsor

openjdk · 2021-05-17T06:26:50Z

@Wanghuang-Huawei Pushed as commit 0b2f1aa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk · 2021-05-17T06:27:18Z

@Wanghuang-Huawei The command sponsor can only be used in open pull requests.

8266775: Add VectorLoadConst node implementation for Arm SVE

b8b662d

openjdk bot added the rfr label May 8, 2021

fix cost

ad86b7a

XiaohongGong reviewed May 10, 2021

View reviewed changes

use sve_index

06f3b97

nsjian reviewed May 12, 2021

View reviewed changes

Wanghuang-Huawei added 2 commits May 12, 2021 15:06

trivial fix

9c7f930

add blank line

c26e5dd

XiaohongGong approved these changes May 14, 2021

View reviewed changes

openjdk bot added the ready label May 14, 2021

nsjian approved these changes May 14, 2021

View reviewed changes

openjdk bot closed this May 17, 2021

openjdk bot added integrated and removed ready rfr labels May 17, 2021

8266775: Add VectorLoadConst node implementation for Arm SVE #79

8266775: Add VectorLoadConst node implementation for Arm SVE #79

Wanghuang-Huawei commented May 8, 2021 •

edited by openjdk bot

Wanghuang-Huawei commented May 8, 2021

bridgekeeper bot commented May 8, 2021

openjdk bot commented May 8, 2021

openjdk bot commented May 8, 2021

mlbridge bot commented May 8, 2021 •

edited

XiaohongGong May 10, 2021

Wanghuang-Huawei May 11, 2021

nsjian May 12, 2021

Wanghuang-Huawei May 12, 2021

nsjian May 12, 2021

Wanghuang-Huawei May 12, 2021

openjdk bot commented May 14, 2021 •

edited

XiaohongGong commented May 14, 2021

nsjian left a comment

Wanghuang-Huawei commented May 17, 2021

Wanghuang-Huawei commented May 17, 2021

openjdk bot commented May 17, 2021

Wanghuang-Huawei commented May 17, 2021

openjdk bot commented May 17, 2021

openjdk bot commented May 17, 2021

		__ lea(rscratch1, ExternalAddress(StubRoutines::aarch64::vector_iota_indices()));
		__ sve_ld1b(as_FloatRegister($dst$$reg), __ B, ptrue, Address(rscratch1, 0));

		// ------------------------------ Vector Load Const -------------------------------
		instruct loadconB(vReg dst, immI0 src)

		predicate(UseSVE > 0 &&
		n->bottom_type()->is_vect()->element_basic_type() == T_BYTE);

8266775: Add VectorLoadConst node implementation for Arm SVE #79

8266775: Add VectorLoadConst node implementation for Arm SVE #79

Conversation

Wanghuang-Huawei commented May 8, 2021 • edited by openjdk bot

Progress

Issue

Reviewers

Contributors

Reviewing

Wanghuang-Huawei commented May 8, 2021

bridgekeeper bot commented May 8, 2021

openjdk bot commented May 8, 2021

openjdk bot commented May 8, 2021

mlbridge bot commented May 8, 2021 • edited

Webrevs

XiaohongGong May 10, 2021

Choose a reason for hiding this comment

Wanghuang-Huawei May 11, 2021

Choose a reason for hiding this comment

nsjian May 12, 2021

Choose a reason for hiding this comment

Wanghuang-Huawei May 12, 2021

Choose a reason for hiding this comment

nsjian May 12, 2021

Choose a reason for hiding this comment

Wanghuang-Huawei May 12, 2021

Choose a reason for hiding this comment

openjdk bot commented May 14, 2021 • edited

XiaohongGong commented May 14, 2021

nsjian left a comment

Choose a reason for hiding this comment

Wanghuang-Huawei commented May 17, 2021

Wanghuang-Huawei commented May 17, 2021

openjdk bot commented May 17, 2021

Wanghuang-Huawei commented May 17, 2021

openjdk bot commented May 17, 2021

openjdk bot commented May 17, 2021

Wanghuang-Huawei commented May 8, 2021 •

edited by openjdk bot

mlbridge bot commented May 8, 2021 •

edited

openjdk bot commented May 14, 2021 •

edited