-
Notifications
You must be signed in to change notification settings - Fork 42
8266775: Add VectorLoadConst node implementation for Arm SVE #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8266775: Add VectorLoadConst node implementation for Arm SVE #79
Conversation
/contributor add Wang Huang whuang@openjdk.org |
👋 Welcome back whuang! A progress list of the required criteria for merging this PR into |
@Wanghuang-Huawei |
@Wanghuang-Huawei |
Webrevs
|
__ lea(rscratch1, ExternalAddress(StubRoutines::aarch64::vector_iota_indices())); | ||
__ sve_ld1b(as_FloatRegister($dst$$reg), __ B, ptrue, Address(rscratch1, 0)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could it use INDEX <Zd>.<T>, #<imm1>, #<imm2>
(Create index starting from and incremented by immediate) here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great suggestion. I will change that. Thank you.
// ------------------------------ Vector Load Const ------------------------------- | ||
instruct loadconB(vReg dst, immI0 src) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a blank line between them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure.
predicate(UseSVE > 0 && | ||
n->bottom_type()->is_vect()->element_basic_type() == T_BYTE); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the size is 16, the neon pattern will also be matched. Can you please add "UseSVE == 0" for NEON VectorLoadConst patterns?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your review. I have changed that.
@Wanghuang-Huawei This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Looks good to me! I think it's better to also get approved by @nsjian . Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks!
/sponsor |
/integrate |
@Wanghuang-Huawei This change does not need sponsoring - the author is allowed to integrate it. |
/sponsor |
@Wanghuang-Huawei Pushed as commit 0b2f1aa. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
@Wanghuang-Huawei The command |
add new data ingenerate_iota_indices
sve_ld1b
these datasve_index
Thank you for your review. Any suggestion is welcome.
Progress
Issue
Reviewers
Contributors
<whuang@openjdk.org>
<aijiaming1@huawei.com>
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/panama-vector pull/79/head:pull/79
$ git checkout pull/79
Update a local copy of the PR:
$ git checkout pull/79
$ git pull https://git.openjdk.java.net/panama-vector pull/79/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 79
View PR using the GUI difftool:
$ git pr show -t 79
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/panama-vector/pull/79.diff