Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253623: Fastdebug JVM crashes with Vector API when PrintAssembly is turned on #8

Closed
wants to merge 1 commit into from

Conversation

dongbohe
Copy link
Member

@dongbohe dongbohe commented Sep 25, 2020

Contributed-by: wanghuang3@huawei.com


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • JDK-8253623: Fastdebug JVM crashes with Vector API when PrintAssembly is turned on

Reviewers

Contributors

  • Huang Wang <wanghuang3@huawei.com>

Download

$ git fetch https://git.openjdk.java.net/panama-vector pull/8/head:pull/8
$ git checkout pull/8

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 25, 2020

👋 Welcome back dongbohe! A progress list of the required criteria for merging this PR into vectorIntrinsics will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 25, 2020
@dongbohe
Copy link
Member Author

@dongbohe dongbohe commented Sep 25, 2020

/contributor add Huang Wang wanghuang3@huawei.com

@openjdk
Copy link

@openjdk openjdk bot commented Sep 25, 2020

@dongbohe Could not parse Huang Wang wanghuang3@huawei.com as a valid contributor.
Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

  • /contributor add @openjdk-bot
  • /contributor add duke
  • /contributor add J. Duke <duke@openjdk.org>

@dongbohe
Copy link
Member Author

@dongbohe dongbohe commented Sep 25, 2020

/contributor add Huang Wang wanghuang3@huawei.com

@openjdk
Copy link

@openjdk openjdk bot commented Sep 25, 2020

@dongbohe
Contributor Huang Wang <wanghuang3@huawei.com> successfully added.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 25, 2020

Webrevs

Copy link
Collaborator

@iwanowww iwanowww left a comment

Otherwise, looks good.

@@ -489,6 +489,7 @@ void JVMState::format(PhaseRegAlloc *regalloc, const Node *n, outputStream* st)
ciField* cifield;
if (iklass != NULL) {
st->print(" [");
iklass->nof_nonstatic_fields();
Copy link
Collaborator

@iwanowww iwanowww Sep 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a workaround that initializes ciInstanceKlass::_nonstatic_fields.
Please, add a FIXME comment saying why you need it, so it will be fixed properly later.

Copy link
Member Author

@dongbohe dongbohe Sep 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Collaborator

@iwanowww iwanowww left a comment

Looks good.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 25, 2020

@dongbohe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

8253623: Fastdebug JVM crashes with Vector API when PrintAssembly is turned on

Co-authored-by: Huang Wang <wanghuang3@huawei.com>
Reviewed-by: vlivanov, psandoz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the vectorIntrinsics branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@iwanowww, @PaulSandoz) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Sep 25, 2020
@iwanowww
Copy link
Collaborator

@iwanowww iwanowww commented Sep 25, 2020

(FTR force-pushes are discouraged. They break review history. Instead, it is recommended to commit incremental changes and then the commits are squashed automatically during integration.)

@dongbohe
Copy link
Member Author

@dongbohe dongbohe commented Sep 27, 2020

/intergrate

@dongbohe
Copy link
Member Author

@dongbohe dongbohe commented Sep 27, 2020

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 27, 2020

@dongbohe Unknown command intergrate - for a list of valid commands use /help.

@openjdk openjdk bot added the sponsor label Sep 27, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 27, 2020

@dongbohe
Your change (at version 48bdd7b) is now ready to be sponsored by a Committer.

@nsjian
Copy link
Collaborator

@nsjian nsjian commented Sep 27, 2020

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Sep 27, 2020

@nsjian @dongbohe Pushed as commit 15a2e2d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@nsjian
Copy link
Collaborator

@nsjian nsjian commented Oct 19, 2020

With 8223347 Vector API integrated into jdk mainline, I can reproduce this in jdk mainline. Do you have any plan to bring this to jdk mainline? I am not sure whether this needs a better proper fix as mentioned by @iwanowww

@DamonFool
Copy link
Member

@DamonFool DamonFool commented Oct 22, 2020

@dongbohe
Could this PR also be merged into the jdk main-line repo ASAP?
I also come across this bug with -XX:+PrintOptoAssembly in the jdk repo.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants