8253623: Fastdebug JVM crashes with Vector API when PrintAssembly is turned on #8

dongbohe · 2020-09-25T09:02:52Z

Contributed-by: wanghuang3@huawei.com

Progress

Change must not contain extraneous whitespace
Change must be properly reviewed

Issue

JDK-8253623: Fastdebug JVM crashes with Vector API when PrintAssembly is turned on

Reviewers

Vladimir Ivanov (@iwanowww - Committer)
Paul Sandoz (@PaulSandoz - Committer)

Contributors

Huang Wang <wanghuang3@huawei.com>

Download

$ git fetch https://git.openjdk.java.net/panama-vector pull/8/head:pull/8
$ git checkout pull/8

bridgekeeper · 2020-09-25T09:04:13Z

👋 Welcome back dongbohe! A progress list of the required criteria for merging this PR into vectorIntrinsics will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

dongbohe · 2020-09-25T09:09:19Z

/contributor add Huang Wang wanghuang3@huawei.com

openjdk · 2020-09-25T09:09:52Z

@dongbohe Could not parse Huang Wang wanghuang3@huawei.com as a valid contributor.
Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

/contributor add @openjdk-bot
/contributor add duke
/contributor add J. Duke <duke@openjdk.org>

dongbohe · 2020-09-25T09:11:18Z

/contributor add Huang Wang wanghuang3@huawei.com

openjdk · 2020-09-25T09:11:47Z

@dongbohe
Contributor Huang Wang <wanghuang3@huawei.com> successfully added.

mlbridge · 2020-09-25T09:15:22Z

Webrevs

01: Full - Incremental (48bdd7b)
00: Full (ddaeb65)

iwanowww

Otherwise, looks good.

iwanowww · 2020-09-25T09:22:32Z

src/hotspot/share/opto/callnode.cpp

@@ -489,6 +489,7 @@ void JVMState::format(PhaseRegAlloc *regalloc, const Node *n, outputStream* st)
        ciField* cifield;
        if (iklass != NULL) {
          st->print(" [");
+          iklass->nof_nonstatic_fields();


It's a workaround that initializes ciInstanceKlass::_nonstatic_fields.
Please, add a FIXME comment saying why you need it, so it will be fixed properly later.

…turned on

iwanowww

Looks good.

openjdk · 2020-09-25T11:05:27Z

@dongbohe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

8253623: Fastdebug JVM crashes with Vector API when PrintAssembly is turned on

Co-authored-by: Huang Wang <wanghuang3@huawei.com>
Reviewed-by: vlivanov, psandoz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the vectorIntrinsics branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@iwanowww, @PaulSandoz) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

iwanowww · 2020-09-25T11:07:41Z

(FTR force-pushes are discouraged. They break review history. Instead, it is recommended to commit incremental changes and then the commits are squashed automatically during integration.)

dongbohe · 2020-09-27T06:54:19Z

/intergrate

dongbohe · 2020-09-27T06:54:34Z

/integrate

openjdk · 2020-09-27T06:55:03Z

@dongbohe Unknown command intergrate - for a list of valid commands use /help.

openjdk · 2020-09-27T06:55:39Z

@dongbohe
Your change (at version 48bdd7b) is now ready to be sponsored by a Committer.

nsjian · 2020-09-27T07:06:48Z

/sponsor

openjdk · 2020-09-27T07:07:41Z

@nsjian @dongbohe Pushed as commit 15a2e2d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

nsjian · 2020-10-19T10:36:09Z

With 8223347 Vector API integrated into jdk mainline, I can reproduce this in jdk mainline. Do you have any plan to bring this to jdk mainline? I am not sure whether this needs a better proper fix as mentioned by @iwanowww

DamonFool · 2020-10-22T13:14:28Z

@dongbohe
Could this PR also be merged into the jdk main-line repo ASAP?
I also come across this bug with -XX:+PrintOptoAssembly in the jdk repo.
Thanks.

openjdk bot added the rfr label Sep 25, 2020

iwanowww suggested changes Sep 25, 2020

View changes

8253623: Fastdebug JVM crashes with Vector API when PrintAssembly is …

48bdd7b

…turned on

dongbohe force-pushed the vector branch from ddaeb65 to 48bdd7b Compare Sep 25, 2020

iwanowww approved these changes Sep 25, 2020

View changes

openjdk bot added the ready label Sep 25, 2020

PaulSandoz approved these changes Sep 25, 2020

View changes

openjdk bot added the sponsor label Sep 27, 2020

openjdk bot closed this Sep 27, 2020

openjdk bot added integrated and removed sponsor ready rfr labels Sep 27, 2020

dongbohe mentioned this pull request Oct 25, 2020

8255448: Fastdebug JVM crashes with Vector API when PrintAssembly is turned on openjdk/jdk#853

Closed

3 tasks

8253623: Fastdebug JVM crashes with Vector API when PrintAssembly is turned on #8

8253623: Fastdebug JVM crashes with Vector API when PrintAssembly is turned on #8

dongbohe commented Sep 25, 2020 •

edited by openjdk[bot] bot

bridgekeeper bot commented Sep 25, 2020

dongbohe commented Sep 25, 2020 •

edited

openjdk bot commented Sep 25, 2020

dongbohe commented Sep 25, 2020

openjdk bot commented Sep 25, 2020

mlbridge bot commented Sep 25, 2020 •

edited

iwanowww left a comment

iwanowww Sep 25, 2020

dongbohe Sep 25, 2020

iwanowww left a comment

openjdk bot commented Sep 25, 2020 •

edited

iwanowww commented Sep 25, 2020

dongbohe commented Sep 27, 2020

dongbohe commented Sep 27, 2020

openjdk bot commented Sep 27, 2020

openjdk bot commented Sep 27, 2020

nsjian commented Sep 27, 2020

openjdk bot commented Sep 27, 2020

nsjian commented Oct 19, 2020

DamonFool commented Oct 22, 2020

8253623: Fastdebug JVM crashes with Vector API when PrintAssembly is turned on #8

8253623: Fastdebug JVM crashes with Vector API when PrintAssembly is turned on #8

Conversation

dongbohe commented Sep 25, 2020 • edited by openjdk[bot] bot

Progress

Issue

Reviewers

Contributors

Download

bridgekeeper bot commented Sep 25, 2020

dongbohe commented Sep 25, 2020 • edited

openjdk bot commented Sep 25, 2020

dongbohe commented Sep 25, 2020

openjdk bot commented Sep 25, 2020

mlbridge bot commented Sep 25, 2020 • edited

Webrevs

iwanowww left a comment

iwanowww Sep 25, 2020

Choose a reason for hiding this comment

dongbohe Sep 25, 2020

Choose a reason for hiding this comment

iwanowww left a comment

openjdk bot commented Sep 25, 2020 • edited

iwanowww commented Sep 25, 2020

dongbohe commented Sep 27, 2020

dongbohe commented Sep 27, 2020

openjdk bot commented Sep 27, 2020

openjdk bot commented Sep 27, 2020

nsjian commented Sep 27, 2020

openjdk bot commented Sep 27, 2020

nsjian commented Oct 19, 2020

DamonFool commented Oct 22, 2020

dongbohe commented Sep 25, 2020 •

edited by openjdk[bot] bot

dongbohe commented Sep 25, 2020 •

edited

mlbridge bot commented Sep 25, 2020 •

edited

openjdk bot commented Sep 25, 2020 •

edited