Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8267224: Vector API SVE codegen cleanups #82

Closed
wants to merge 1 commit into from

Conversation

@nsjian
Copy link
Collaborator

@nsjian nsjian commented May 17, 2021

Some code cleanups for SVE:

  • Revert sve_dup assembler changes, as well as similar changes to sve_cpy assembler. See [1].
  • Refactor fcvt/fcvtzs/scvtf assembler code.
  • Add more assembler tests to make sure the coverage for newly added assembler routines.
  • Fix gather/scatter addressing issue.
  • Some code style cleanups.
  • Merge some matching patterns.

[1] openjdk/jdk#1307


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/panama-vector pull/82/head:pull/82
$ git checkout pull/82

Update a local copy of the PR:
$ git checkout pull/82
$ git pull https://git.openjdk.java.net/panama-vector pull/82/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 82

View PR using the GUI difftool:
$ git pr show -t 82

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/panama-vector/pull/82.diff

- Revert sve_dup assembler changes, as well as similar changes to
  sve_cpy assembler. See [1].
- Refactor fcvt/fcvtzs/scvtf assembler code.
- Add more assembler tests to make sure the coverage for newly added
  assembler routines.
- Fix gather/scatter addressing issue.
- Some code style cleanups.
- Merge some matching patterns.

[1] openjdk/jdk#1307
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 17, 2021

👋 Welcome back njian! A progress list of the required criteria for merging this PR into vectorIntrinsics will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label May 17, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 17, 2021

Webrevs

@XiaohongGong
Copy link
Collaborator

@XiaohongGong XiaohongGong commented May 18, 2021

Looks good to me. Thanks!

@openjdk
Copy link

@openjdk openjdk bot commented May 18, 2021

@nsjian This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267224: Vector API SVE codegen cleanups

Reviewed-by: xgong

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the vectorIntrinsics branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the vectorIntrinsics branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 18, 2021
@nsjian
Copy link
Collaborator Author

@nsjian nsjian commented May 18, 2021

/integrate

@openjdk openjdk bot closed this May 18, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 18, 2021

@nsjian Pushed as commit 34ca549.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants