Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8263532: C2: Improve vector box elimination for Phi nodes #84

Closed
wants to merge 2 commits into from

Conversation

@iwanowww
Copy link
Collaborator

@iwanowww iwanowww commented May 18, 2021

Enhance vector box elimination when merging VectorBox nodes through Phis.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • JDK-8263532: C2: Improve vector box elimination for Phi nodes

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/panama-vector pull/84/head:pull/84
$ git checkout pull/84

Update a local copy of the PR:
$ git checkout pull/84
$ git pull https://git.openjdk.java.net/panama-vector pull/84/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 84

View PR using the GUI difftool:
$ git pr show -t 84

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/panama-vector/pull/84.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 18, 2021

👋 Welcome back vlivanov! A progress list of the required criteria for merging this PR into vectorIntrinsics will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label May 18, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 18, 2021

Webrevs

Copy link
Member

@PaulSandoz PaulSandoz left a comment

Rubber stamped.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 26, 2021

@iwanowww This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263532: C2: Improve vector box elimination for Phi nodes

Reviewed-by: psandoz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2988 new commits pushed to the vectorIntrinsics branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the vectorIntrinsics branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 26, 2021
@iwanowww
Copy link
Collaborator Author

@iwanowww iwanowww commented Aug 26, 2021

Thanks, Paul.

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Aug 26, 2021

Going to push as commit dca538d.
Since your change was applied there have been 2988 commits pushed to the vectorIntrinsics branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 26, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 26, 2021

@iwanowww Pushed as commit dca538d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants