New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8266286: Add LoadVectorGather and StoreVectorScatter's partial version #87
8266286: Add LoadVectorGather and StoreVectorScatter's partial version #87
Conversation
/contributor Wang Huang whuang@openjdk.org |
👋 Welcome back whuang! A progress list of the required criteria for merging this PR into |
To avoid this situation, create a new branch for your changes and reset the
Then proceed to create a new pull request with |
@Wanghuang-Huawei Syntax:
|
@Wanghuang-Huawei Syntax:
|
Webrevs
|
/contributor Wang Huang whuang@openjdk.org |
@Wanghuang-Huawei Syntax:
|
@Wanghuang-Huawei Syntax:
|
/contributor add Wang Huang whuang@openjdk.org |
@Wanghuang-Huawei |
@Wanghuang-Huawei |
// ------------------------------ Vector Load Gather Partial------------------------------- | ||
instruct gatherI_partial(vReg dst, indirect mem, vReg idx, pRegGov pTmp, rFlagsReg cr) %{ | ||
predicate(UseSVE > 0 && | ||
n->as_LoadVectorGather()->memory_size() >= 16 && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there is the min vector size (size in byte >= 16) limitation in op_sve_supported
, is this needed here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. Thank you for your review. I will change that.
7a87daf
to
5f57f54
Compare
sve_whilelo
Progress
Issue
Contributors
<whuang@openjdk.org>
<aijiaming1@huawei.com>
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/panama-vector pull/87/head:pull/87
$ git checkout pull/87
Update a local copy of the PR:
$ git checkout pull/87
$ git pull https://git.openjdk.java.net/panama-vector pull/87/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 87
View PR using the GUI difftool:
$ git pr show -t 87
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/panama-vector/pull/87.diff