Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8266286: Add LoadVectorGather and StoreVectorScatter's partial version #87

Conversation

@Wanghuang-Huawei
Copy link
Collaborator

@Wanghuang-Huawei Wanghuang-Huawei commented May 28, 2021

  • Add LoadVectorGather and StoreVectorScatter's partial version
  • use sve_whilelo

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • JDK-8266286: Add LoadVectorGather and StoreVectorScatter's partial version

Contributors

  • Wang Huang <whuang@openjdk.org>
  • Ai Jiaming <aijiaming1@huawei.com>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/panama-vector pull/87/head:pull/87
$ git checkout pull/87

Update a local copy of the PR:
$ git checkout pull/87
$ git pull https://git.openjdk.java.net/panama-vector pull/87/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 87

View PR using the GUI difftool:
$ git pr show -t 87

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/panama-vector/pull/87.diff

@Wanghuang-Huawei
Copy link
Collaborator Author

@Wanghuang-Huawei Wanghuang-Huawei commented May 28, 2021

/contributor Wang Huang whuang@openjdk.org
/contributor Ai Jiaming aijiaming1@huawei.com

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 28, 2021

👋 Welcome back whuang! A progress list of the required criteria for merging this PR into vectorIntrinsics will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented May 28, 2021

⚠️ @Wanghuang-Huawei a branch with the same name as the source branch for this pull request (vectorIntrinsics) is present in the target repository. If you eventually integrate this pull request then the branch vectorIntrinsics in your personal fork will diverge once you sync your personal fork with the upstream repository.

To avoid this situation, create a new branch for your changes and reset the vectorIntrinsics branch. You can do this by running the following commands in a local repository for your personal fork. Note: you do not have to name the new branch NEW-BRANCH-NAME.

$ git checkout -b NEW-BRANCH-NAME
$ git branch -f vectorIntrinsics 5f57f548f1c4e5f46c702fda87db6dc282a9f1d1
$ git push -f origin vectorIntrinsics

Then proceed to create a new pull request with NEW-BRANCH-NAME as the source branch and close this one.

@openjdk openjdk bot added the rfr label May 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 28, 2021

@Wanghuang-Huawei Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

  • /contributor add @openjdk-bot
  • /contributor add duke
  • /contributor add J. Duke <duke@openjdk.org>

@openjdk
Copy link

@openjdk openjdk bot commented May 28, 2021

@Wanghuang-Huawei Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

  • /contributor add @openjdk-bot
  • /contributor add duke
  • /contributor add J. Duke <duke@openjdk.org>

@mlbridge
Copy link

@mlbridge mlbridge bot commented May 28, 2021

Webrevs

@Wanghuang-Huawei
Copy link
Collaborator Author

@Wanghuang-Huawei Wanghuang-Huawei commented May 29, 2021

/contributor Wang Huang whuang@openjdk.org
/contributor Ai Jiaming aijiaming1@huawei.com

@openjdk
Copy link

@openjdk openjdk bot commented May 29, 2021

@Wanghuang-Huawei Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

  • /contributor add @openjdk-bot
  • /contributor add duke
  • /contributor add J. Duke <duke@openjdk.org>

@openjdk
Copy link

@openjdk openjdk bot commented May 29, 2021

@Wanghuang-Huawei Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

  • /contributor add @openjdk-bot
  • /contributor add duke
  • /contributor add J. Duke <duke@openjdk.org>

@Wanghuang-Huawei
Copy link
Collaborator Author

@Wanghuang-Huawei Wanghuang-Huawei commented May 29, 2021

/contributor add Wang Huang whuang@openjdk.org
/contributor add Ai Jiaming aijiaming1@huawei.com

@openjdk
Copy link

@openjdk openjdk bot commented May 29, 2021

@Wanghuang-Huawei
Contributor Wang Huang <whuang@openjdk.org> successfully added.

@openjdk
Copy link

@openjdk openjdk bot commented May 29, 2021

@Wanghuang-Huawei
Contributor Ai Jiaming <aijiaming1@huawei.com> successfully added.

// ------------------------------ Vector Load Gather Partial-------------------------------
instruct gatherI_partial(vReg dst, indirect mem, vReg idx, pRegGov pTmp, rFlagsReg cr) %{
predicate(UseSVE > 0 &&
n->as_LoadVectorGather()->memory_size() >= 16 &&
Copy link
Collaborator

@XiaohongGong XiaohongGong May 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there is the min vector size (size in byte >= 16) limitation in op_sve_supported, is this needed here?

Copy link
Collaborator Author

@Wanghuang-Huawei Wanghuang-Huawei May 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Thank you for your review. I will change that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 participants