-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8283865: riscv: Break down -XX:+UseRVB into seperate options for each bitmanip extension #13
Conversation
…ions for each bitmanip extension
👋 Welcome back gcao! A progress list of the required criteria for merging this PR into |
@zifeihan This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 19 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backport looks good. Thanks.
@RealFYang : Thanks for the review. |
/sponsor |
Going to push as commit aee4eea.
Your commit was automatically rebased without conflicts. |
@RealFYang @zifeihan Pushed as commit aee4eea. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi, The same issue[1] also exists in the riscv-port-jdk11u. According to the spec, we need to break down UseRVB into two individual options UseZba and UseZbb to enable or disable Zba and Zbb respectively.
Linux RISCV64 release hotspot/jdk tier1 tests are passed on QEMU with following options:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/riscv-port-jdk11u.git pull/13/head:pull/13
$ git checkout pull/13
Update a local copy of the PR:
$ git checkout pull/13
$ git pull https://git.openjdk.org/riscv-port-jdk11u.git pull/13/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 13
View PR using the GUI difftool:
$ git pr show -t 13
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/riscv-port-jdk11u/pull/13.diff
Webrev
Link to Webrev Comment