Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8328948: GHA: Restoring sysroot from cache skips the build after JDK-8326960 #15

Closed
wants to merge 2 commits into from

Conversation

RealFYang
Copy link
Member

@RealFYang RealFYang commented Mar 26, 2024

Fixes a recent GHA regression. Applies cleanly.

  • GHA, first run passes cross-builds
  • GHA, second run passes cross-builds

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8328948: GHA: Restoring sysroot from cache skips the build after JDK-8326960 (Bug - P1)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/riscv-port-jdk11u.git pull/15/head:pull/15
$ git checkout pull/15

Update a local copy of the PR:
$ git checkout pull/15
$ git pull https://git.openjdk.org/riscv-port-jdk11u.git pull/15/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15

View PR using the GUI difftool:
$ git pr show -t 15

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/riscv-port-jdk11u/pull/15.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 26, 2024

👋 Welcome back fyang! A progress list of the required criteria for merging this PR into riscv-port will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 26, 2024

@RealFYang This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8328948: GHA: Restoring sysroot from cache skips the build after JDK-8326960

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the riscv-port branch:

  • aee4eea: 8283865: riscv: Break down -XX:+UseRVB into seperate options for each bitmanip extension

Please see this link for an up-to-date comparison between the source branch of this pull request and the riscv-port branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the riscv-port branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 447436e18c754424a62af5135fb3a8973564091d 8328948: GHA: Restoring sysroot from cache skips the build after JDK-8326960 Mar 26, 2024
@openjdk
Copy link

openjdk bot commented Mar 26, 2024

This backport pull request has now been updated with issue from the original commit.

@RealFYang RealFYang requested a review from shipilev March 26, 2024 00:36
@RealFYang RealFYang marked this pull request as ready for review March 26, 2024 01:07
@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 26, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 26, 2024

Webrevs

@RealFYang
Copy link
Member Author

@shipilev : Could you please take another look? Thanks.

@RealFYang
Copy link
Member Author

Let's get this merged ASAP then :-)
/integrate

@openjdk
Copy link

openjdk bot commented Mar 26, 2024

Going to push as commit f71648c.
Since your change was applied there has been 1 commit pushed to the riscv-port branch:

  • aee4eea: 8283865: riscv: Break down -XX:+UseRVB into seperate options for each bitmanip extension

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 26, 2024
@openjdk openjdk bot closed this Mar 26, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 26, 2024
@openjdk
Copy link

openjdk bot commented Mar 26, 2024

@RealFYang Pushed as commit f71648c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealFYang RealFYang deleted the 8328948-backport branch April 1, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants