-
Notifications
You must be signed in to change notification settings - Fork 9
8291893: riscv: remove fence.i used in user space #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back gcao! A progress list of the required criteria for merging this PR into |
@zifeihan This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
Let's make sure we backport openjdk/jdk@faf1b82 as well as it's a fix for the commit you're backporting here. |
Webrevs
|
85db9b2
to
6db0c80
Compare
@zifeihan Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
/issue add 8291947, 8310656 |
@zifeihan Adding additional issue to issue list: |
Hi, Thanks for your review. I've backported 8310656 and added a new commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated change looks good to me. Thanks.
@RealFYang @luhenry : Thanks for the review. |
/sponsor |
Going to push as commit d4b0021. |
@RealFYang @zifeihan Pushed as commit d4b0021. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please help review this backport to riscv-port-jdk11u.
Backport of JDK-8291893
In addition to the backport 8291947, 8310656 to align and minimize the difference with 17u upstream.
Testing:
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/riscv-port-jdk11u.git pull/16/head:pull/16
$ git checkout pull/16
Update a local copy of the PR:
$ git checkout pull/16
$ git pull https://git.openjdk.org/riscv-port-jdk11u.git pull/16/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 16
View PR using the GUI difftool:
$ git pr show -t 16
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/riscv-port-jdk11u/pull/16.diff
Webrev
Link to Webrev Comment