Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8291893: riscv: remove fence.i used in user space #16

Closed
wants to merge 4 commits into from

Conversation

zifeihan
Copy link
Member

@zifeihan zifeihan commented Mar 26, 2024

Please help review this backport to riscv-port-jdk11u.
Backport of JDK-8291893

In addition to the backport 8291947, 8310656 to align and minimize the difference with 17u upstream.

Testing:

  • Run tier1-3 tests on SOPHON SG2042 (release)

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8291893: riscv: remove fence.i used in user space (Enhancement - P4)
  • JDK-8291947: riscv: fail to build after JDK-8290840 (Bug - P3)
  • JDK-8310656: RISC-V: __builtin___clear_cache can fail silently. (Bug - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/riscv-port-jdk11u.git pull/16/head:pull/16
$ git checkout pull/16

Update a local copy of the PR:
$ git checkout pull/16
$ git pull https://git.openjdk.org/riscv-port-jdk11u.git pull/16/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16

View PR using the GUI difftool:
$ git pr show -t 16

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/riscv-port-jdk11u/pull/16.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 26, 2024

👋 Welcome back gcao! A progress list of the required criteria for merging this PR into riscv-port will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 26, 2024

@zifeihan This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8291893: riscv: remove fence.i used in user space
8291947: riscv: fail to build after JDK-8290840
8310656: RISC-V: __builtin___clear_cache can fail silently.

Reviewed-by: fyang, luhenry

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the riscv-port branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 5a539e8da7dbea1eaa10d799f75199ea359f7a22 8291893: riscv: remove fence.i used in user space Mar 26, 2024
@openjdk
Copy link

openjdk bot commented Mar 26, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Mar 26, 2024
@luhenry
Copy link
Member

luhenry commented Mar 26, 2024

Let's make sure we backport openjdk/jdk@faf1b82 as well as it's a fix for the commit you're backporting here.

@zifeihan zifeihan marked this pull request as ready for review March 27, 2024 06:52
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 27, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 27, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 27, 2024

@zifeihan Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@zifeihan
Copy link
Member Author

/issue add 8291947, 8310656

@openjdk
Copy link

openjdk bot commented Mar 27, 2024

@zifeihan
Adding additional issue to issue list: 8291947: riscv: fail to build after JDK-8290840.

Adding additional issue to issue list: 8310656: RISC-V: __builtin___clear_cache can fail silently..

@zifeihan
Copy link
Member Author

Let's make sure we backport openjdk/jdk@faf1b82 as well as it's a fix for the commit you're backporting here.

Hi, Thanks for your review. I've backported 8310656 and added a new commit.

Copy link
Member

@RealFYang RealFYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated change looks good to me. Thanks.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 28, 2024
@zifeihan
Copy link
Member Author

@RealFYang @luhenry : Thanks for the review.
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 29, 2024
@openjdk
Copy link

openjdk bot commented Mar 29, 2024

@zifeihan
Your change (at version 383fd35) is now ready to be sponsored by a Committer.

@RealFYang
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 29, 2024

Going to push as commit d4b0021.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 29, 2024
@openjdk openjdk bot closed this Mar 29, 2024
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Mar 29, 2024
@openjdk openjdk bot removed rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 29, 2024
@openjdk
Copy link

openjdk bot commented Mar 29, 2024

@RealFYang @zifeihan Pushed as commit d4b0021.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@zifeihan zifeihan deleted the backport-JDK-8291893 branch April 1, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
3 participants