-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8297697: RISC-V: Add support for SATP mode detection #19
Conversation
👋 Welcome back gcao! A progress list of the required criteria for merging this PR into |
/issue JDK-8301067 |
@zifeihan This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 14 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
@zifeihan |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thanks.
@RealFYang @feilongjiang : Thanks for the review. |
/sponsor |
Going to push as commit e14708a.
Your commit was automatically rebased without conflicts. |
@RealFYang @zifeihan Pushed as commit e14708a. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi,
Please review this backport to riscv-port-jdk11u.
Backport of JDK-8297697, and JDK-8301067. JDK-8301067 only modifies the log description information introduced by JDK-8297697.
After this patch, If it is an unsupported satp.mode , the message will be as follows:
Testing:
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/riscv-port-jdk11u.git pull/19/head:pull/19
$ git checkout pull/19
Update a local copy of the PR:
$ git checkout pull/19
$ git pull https://git.openjdk.org/riscv-port-jdk11u.git pull/19/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 19
View PR using the GUI difftool:
$ git pr show -t 19
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/riscv-port-jdk11u/pull/19.diff
Webrev
Link to Webrev Comment