-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8309258: RISC-V: Add riscv_hwprobe syscall #20
Conversation
👋 Welcome back gcao! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
/issue add 8315206 |
@zifeihan |
@zifeihan |
@zifeihan |
@zifeihan |
Webrevs
|
I see the original commit of https://bugs.openjdk.org/browse/JDK-8309258 touches |
Hi, Thanks for your review. You are right, I've submitted #21 backport pr. |
@zifeihan This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
@zifeihan This pull request has been inactive for more than 16 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
Hi,
Please help review this backport to riscv-port-jdk11u.
Backport of 8309258, 8315206, 8316859, 8324280, 8315652
Since 8315195 hasn't been backported yet, the RVV,Zba,Zbb extension hasn't been turned on automatically yet.
This backport adds the syscall, uses the syscall in combination with the aux and cpuinfo to enable features by default.
The following changes were added to the original patch to avoid build errors:
enum VM_MODE
instead ofenum UNALIGNED_ACCESS : int
to avoid c++ build warnings, this is c++11 feature. build log like this :NULL
instead ofnullptr
#include "memory/allocation.hpp"
instead of#include "memory/allStatic.hpp"
Testing on SOPHON SG2042
test/lib/sun/hotspot/cpuinfo/CPUInfo.java log like this:
Testing on qemu-system
test/lib/sun/hotspot/cpuinfo/CPUInfo.java log like this:
Testing
Progress
Issues
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/riscv-port-jdk11u.git pull/20/head:pull/20
$ git checkout pull/20
Update a local copy of the PR:
$ git checkout pull/20
$ git pull https://git.openjdk.org/riscv-port-jdk11u.git pull/20/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 20
View PR using the GUI difftool:
$ git pr show -t 20
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/riscv-port-jdk11u/pull/20.diff
Webrev
Link to Webrev Comment