Skip to content

Conversation

@DingliZhang
Copy link
Member

@DingliZhang DingliZhang commented Aug 8, 2024

Please review this backport to riscv-port-jdk11u.
Backport of JDK-8299847.
The original patch cannot be directly applied because of the line number, but there are no other additional changes.

Testing:

  • Tier1 passed w/o new failure on LPi4A(release).

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8299847: RISC-V: Improve PrintOptoAssembly output of CMoveI/L nodes (Bug - P5)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/riscv-port-jdk11u.git pull/24/head:pull/24
$ git checkout pull/24

Update a local copy of the PR:
$ git checkout pull/24
$ git pull https://git.openjdk.org/riscv-port-jdk11u.git pull/24/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24

View PR using the GUI difftool:
$ git pr show -t 24

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/riscv-port-jdk11u/pull/24.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 8, 2024

👋 Welcome back dzhang! A progress list of the required criteria for merging this PR into riscv-port will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 8, 2024

@DingliZhang This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8299847: RISC-V: Improve PrintOptoAssembly output of CMoveI/L nodes

Reviewed-by: fyang, gcao, mli

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 151 new commits pushed to the riscv-port branch:

  • eff8723: Merge branch 'master' into riscv-port
  • 3acdebe: 8229822: ThrowingPushPromises tests sometimes fail due to EOF
  • c5d2cc1: 8336301: test/jdk/java/nio/channels/AsyncCloseAndInterrupt.java leaves around a FIFO file upon test completion
  • 7d34693: 8317358: G1: Make TestMaxNewSize use createTestJvm
  • 1daafdd: 8317343: GC: Make TestHeapFreeRatio use createTestJvm
  • 8ef8482: 8334711: [TEST_BUG] Compilation failed of MimeFormatsTest/MimeFormatsTest.java
  • 7547abf: 8255913: Decrease number of iterations in TestMaxCachedBufferSize
  • ee57792: 8259274: Increase timeout duration in sun/nio/ch/TestMaxCachedBufferSize.java
  • d668844: 8298873: Update IllegalRecordVersion.java for changes to TLS implementation
  • 95c0b97: 8244966: Add .vscode to .hgignore and .gitignore
  • ... and 141 more: https://git.openjdk.org/riscv-port-jdk11u/compare/1e43225ea39ddb69fd406dba0ab56665187fde12...riscv-port

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang, @zifeihan) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title backport 859ccd1a150653c42ebbcd3402994ef9ff4c810f 8299847: RISC-V: Improve PrintOptoAssembly output of CMoveI/L nodes Aug 8, 2024
@openjdk
Copy link

openjdk bot commented Aug 8, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Aug 8, 2024
@mlbridge
Copy link

mlbridge bot commented Aug 8, 2024

Webrevs

Copy link
Member

@RealFYang RealFYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 8, 2024
@openjdk openjdk bot added ready Pull request is ready to be integrated and removed ready Pull request is ready to be integrated labels Aug 8, 2024
@DingliZhang
Copy link
Member Author

Thanks for the review!
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 8, 2024
@openjdk
Copy link

openjdk bot commented Aug 8, 2024

@DingliZhang
Your change (at version 88f2561) is now ready to be sponsored by a Committer.

@zifeihan
Copy link
Member

zifeihan commented Aug 8, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 8, 2024

Going to push as commit e022ea6.
Since your change was applied there have been 151 commits pushed to the riscv-port branch:

  • eff8723: Merge branch 'master' into riscv-port
  • 3acdebe: 8229822: ThrowingPushPromises tests sometimes fail due to EOF
  • c5d2cc1: 8336301: test/jdk/java/nio/channels/AsyncCloseAndInterrupt.java leaves around a FIFO file upon test completion
  • 7d34693: 8317358: G1: Make TestMaxNewSize use createTestJvm
  • 1daafdd: 8317343: GC: Make TestHeapFreeRatio use createTestJvm
  • 8ef8482: 8334711: [TEST_BUG] Compilation failed of MimeFormatsTest/MimeFormatsTest.java
  • 7547abf: 8255913: Decrease number of iterations in TestMaxCachedBufferSize
  • ee57792: 8259274: Increase timeout duration in sun/nio/ch/TestMaxCachedBufferSize.java
  • d668844: 8298873: Update IllegalRecordVersion.java for changes to TLS implementation
  • 95c0b97: 8244966: Add .vscode to .hgignore and .gitignore
  • ... and 141 more: https://git.openjdk.org/riscv-port-jdk11u/compare/1e43225ea39ddb69fd406dba0ab56665187fde12...riscv-port

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 8, 2024
@openjdk openjdk bot closed this Aug 8, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 8, 2024
@openjdk
Copy link

openjdk bot commented Aug 8, 2024

@zifeihan @DingliZhang Pushed as commit e022ea6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants