-
Notifications
You must be signed in to change notification settings - Fork 9
8301313: RISC-V: C2: assert(false) failed: bad AD file due to missing match rule #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back dzhang! A progress list of the required criteria for merging this PR into |
@DingliZhang This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang, @zifeihan) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
Some of the tests are still in progress and I will update the results later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Tier1 all passed on LPi4A (release). |
Thanks for the review! |
@DingliZhang |
/sponsor |
Going to push as commit a42312b. |
@zifeihan @DingliZhang Pushed as commit a42312b. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review this backport to riscv-port-jdk11u. Backport of JDK-8301313.
Due to the line numbers and the lack of C2_MacroAssembler in jdk11, it is not possible to apply the original patch directly.
This PR will solve the following problem:
We noticed that slowdebug builds failed on openEuler build system due to bad AD files after upgrading to version 11.0.24-ga.
The issue can be reproduced on LPi4A using the riscv-port branch with the following command:
Corresponding log file:
https://cr.openjdk.org/~dzhang/riscv-port-jdk11u/8301313/build.log
https://cr.openjdk.org/~dzhang/riscv-port-jdk11u/8301313/configure.log
https://cr.openjdk.org/~dzhang/riscv-port-jdk11u/8301313/hs_err_pid395981.log
Testing:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/riscv-port-jdk11u.git pull/25/head:pull/25
$ git checkout pull/25
Update a local copy of the PR:
$ git checkout pull/25
$ git pull https://git.openjdk.org/riscv-port-jdk11u.git pull/25/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25
View PR using the GUI difftool:
$ git pr show -t 25
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/riscv-port-jdk11u/pull/25.diff
Webrev
Link to Webrev Comment