Skip to content

8301313: RISC-V: C2: assert(false) failed: bad AD file due to missing match rule #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

DingliZhang
Copy link
Member

@DingliZhang DingliZhang commented Aug 8, 2024

Please review this backport to riscv-port-jdk11u. Backport of JDK-8301313.
Due to the line numbers and the lack of C2_MacroAssembler in jdk11, it is not possible to apply the original patch directly.

This PR will solve the following problem:
We noticed that slowdebug builds failed on openEuler build system due to bad AD files after upgrading to version 11.0.24-ga.
The issue can be reproduced on LPi4A using the riscv-port branch with the following command:

bash configure \
--with-boot-jdk=$HOME/jdk-bin/openjdk-11/jdk \
--disable-warnings-as-errors \
--with-debug-level=slowdebug \
--with-native-debug-symbols=internal
make images

Corresponding log file:
https://cr.openjdk.org/~dzhang/riscv-port-jdk11u/8301313/build.log
https://cr.openjdk.org/~dzhang/riscv-port-jdk11u/8301313/configure.log
https://cr.openjdk.org/~dzhang/riscv-port-jdk11u/8301313/hs_err_pid395981.log

Testing:

  • Native slowdebug build on LPi4A
  • Tier1 passed w/o new failure on LPi4A (release)

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8301313: RISC-V: C2: assert(false) failed: bad AD file due to missing match rule (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/riscv-port-jdk11u.git pull/25/head:pull/25
$ git checkout pull/25

Update a local copy of the PR:
$ git checkout pull/25
$ git pull https://git.openjdk.org/riscv-port-jdk11u.git pull/25/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25

View PR using the GUI difftool:
$ git pr show -t 25

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/riscv-port-jdk11u/pull/25.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 8, 2024

👋 Welcome back dzhang! A progress list of the required criteria for merging this PR into riscv-port will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 8, 2024

@DingliZhang This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8301313: RISC-V: C2: assert(false) failed: bad AD file due to missing match rule

Reviewed-by: fyang, gcao

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the riscv-port branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang, @zifeihan) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 3ad6aef1496de914b70f00005465e4b22f248d4f 8301313: RISC-V: C2: assert(false) failed: bad AD file due to missing match rule Aug 8, 2024
@openjdk
Copy link

openjdk bot commented Aug 8, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Aug 8, 2024
@mlbridge
Copy link

mlbridge bot commented Aug 8, 2024

Webrevs

@DingliZhang
Copy link
Member Author

Some of the tests are still in progress and I will update the results later.

Copy link
Member

@RealFYang RealFYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 8, 2024
Copy link
Member

@zifeihan zifeihan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@DingliZhang
Copy link
Member Author

Tier1 all passed on LPi4A (release).

@DingliZhang
Copy link
Member Author

Thanks for the review!
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 9, 2024
@openjdk
Copy link

openjdk bot commented Aug 9, 2024

@DingliZhang
Your change (at version c42d509) is now ready to be sponsored by a Committer.

@zifeihan
Copy link
Member

zifeihan commented Aug 9, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 9, 2024

Going to push as commit a42312b.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 9, 2024
@openjdk openjdk bot closed this Aug 9, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 9, 2024
@openjdk
Copy link

openjdk bot commented Aug 9, 2024

@zifeihan @DingliZhang Pushed as commit a42312b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants