-
Notifications
You must be signed in to change notification settings - Fork 9
8337780: RISC-V: C2: Change C calling convention for sp to NS #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back gcao! A progress list of the required criteria for merging this PR into |
@zifeihan This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I compared some of the C2 runtime stubs, it works as expected.
Thanks for the review. |
Going to push as commit 1f90ddd.
Your commit was automatically rebased without conflicts. |
Hi, Please help review this backport to riscv-port-jdk11u.
Clean backport of JDK-8337780 to reduce frame size by 16 bytes and improve performance for some C2 runtime stubs as we do not have to save sp on the method entry.
Testing
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/riscv-port-jdk11u.git pull/26/head:pull/26
$ git checkout pull/26
Update a local copy of the PR:
$ git checkout pull/26
$ git pull https://git.openjdk.org/riscv-port-jdk11u.git pull/26/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26
View PR using the GUI difftool:
$ git pr show -t 26
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/riscv-port-jdk11u/pull/26.diff
Webrev
Link to Webrev Comment