8293524: RISC-V: Use macro-assembler functions as appropriate

[DingliZhang]

Please review this backport to riscv-port-jdk11u.
Backport of JDK-8293524.
The original patch cannot be directly applied because jdk11u has no JDK-8241436 and JDK-8229258 . Also jdk11u does not have generate_bigIntegerLeftShift and generate_bigIntegerRightShift functions.

Testing:

• Tier1 passed without new failure on lp4a (release).

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8293524: RISC-V: Use macro-assembler functions as appropriate (Enhancement - P4)

Reviewers

• Gui Cao (@zifeihan - Committer)
• Fei Yang (@RealFYang - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/riscv-port-jdk11u.git pull/34/head:pull/34
$ git checkout pull/34

Update a local copy of the PR:
$ git checkout pull/34
$ git pull https://git.openjdk.org/riscv-port-jdk11u.git pull/34/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 34

View PR using the GUI difftool:
$ git pr show -t 34

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/riscv-port-jdk11u/pull/34.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dzhang! A progress list of the required criteria for merging this PR into riscv-port will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@DingliZhang This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8293524: RISC-V: Use macro-assembler functions as appropriate

Reviewed-by: gcao, fyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the riscv-port branch:

• d46c73c: 8293474: RISC-V: Unify the way of moving function pointer
• 7c55d32: Merge branch 'master' into riscv-port
• a754a3d: 8339644: Improve parsing of Day/Month in tzdata rules
• 6436749: Merge
• 82c330b: 8341059: Change Entrust TLS distrust date to November 12, 2024
• 217b9fd: 8341057: Add 2 SSL.com TLS roots
• 2232d1f: 8338402: GHA: some of bundles may not get removed
• 06d87ca: 8299254: Support dealing with standard assert macro
• 0157967: 8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak
• bec83f3: 8211920: Close server socket and cleanups in test/jdk/javax/naming/module/RunBasic.java
• ... and 6 more: https://git.openjdk.org/riscv-port-jdk11u/compare/120e35ec81814eab5b178c81a3790690b5dd7537...riscv-port

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the riscv-port branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 01: Full - Incremental (0c4fca28)
• 00: Full (8140338d)

[zifeihan]

Why is li(result, 1); converted to mv(result, -1);?

[openjdk]

@DingliZhang Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[DingliZhang]

Why is li(result, 1); converted to mv(result, -1);?

Just a typo, sorry.
Fixed.

[zifeihan]

Looks good.

[DingliZhang]

Thanks all for the review.
/integrate

[openjdk]

Going to push as commit 0d7892b.
Since your change was applied there have been 16 commits pushed to the riscv-port branch:

• d46c73c: 8293474: RISC-V: Unify the way of moving function pointer
• 7c55d32: Merge branch 'master' into riscv-port
• a754a3d: 8339644: Improve parsing of Day/Month in tzdata rules
• 6436749: Merge
• 82c330b: 8341059: Change Entrust TLS distrust date to November 12, 2024
• 217b9fd: 8341057: Add 2 SSL.com TLS roots
• 2232d1f: 8338402: GHA: some of bundles may not get removed
• 06d87ca: 8299254: Support dealing with standard assert macro
• 0157967: 8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak
• bec83f3: 8211920: Close server socket and cleanups in test/jdk/javax/naming/module/RunBasic.java
• ... and 6 more: https://git.openjdk.org/riscv-port-jdk11u/compare/120e35ec81814eab5b178c81a3790690b5dd7537...riscv-port

Your commit was automatically rebased without conflicts.

[openjdk]

@DingliZhang Pushed as commit 0d7892b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.