-
Notifications
You must be signed in to change notification settings - Fork 9
8299168: RISC-V: Fix MachNode size mismatch for MacroAssembler::_verify_oops* #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back dzhang! A progress list of the required criteria for merging this PR into |
@DingliZhang This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
The test is in progress and will be updated later with the results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
/home/abuild/rpmbuild/BUILD/jdk11u-jdk-11.0.25-9/src/hotspot/cpu/riscv/macroAssembler_riscv.cpp:391:5: error: 'IncompressibleRegion' was not declared in this scope; did you mean 'CompressibleRegion'? |
Sorry for the confusion. This PR requires a pre-patch . We need to merge these PR in order, so please be patient. |
Thanks, I can confirm that this together with refs/pull/43/head fixes the issue. |
78495b6
to
c0a92f6
Compare
@DingliZhang Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
Thanks for the review. |
Going to push as commit ccbb663. |
@DingliZhang Pushed as commit ccbb663. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review this backport to riscv-port-jdk11u.
Backport of JDK-8299168.
Applies not cleanly due to context difference, but it is easy to resolve them manually.
Testing:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/riscv-port-jdk11u.git pull/42/head:pull/42
$ git checkout pull/42
Update a local copy of the PR:
$ git checkout pull/42
$ git pull https://git.openjdk.org/riscv-port-jdk11u.git pull/42/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 42
View PR using the GUI difftool:
$ git pr show -t 42
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/riscv-port-jdk11u/pull/42.diff
Webrev
Link to Webrev Comment