-
Notifications
You must be signed in to change notification settings - Fork 12
8291947: riscv: fail to build after JDK-8290840 #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back gcao! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
@zifeihan This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@VladimirKempik) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK.
Please review this backport to riscv-port-jdk17u.
Backport of JDK-8291947.
In the current version, https://bugs.openjdk.org/browse/JDK-8290840 has not been refactored, so the issues corresponding to the original issue do not exist. compared to the original patch, the icache_flush function is removed in a different location.
Testing:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/riscv-port-jdk17u pull/15/head:pull/15
$ git checkout pull/15
Update a local copy of the PR:
$ git checkout pull/15
$ git pull https://git.openjdk.org/riscv-port-jdk17u pull/15/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 15
View PR using the GUI difftool:
$ git pr show -t 15
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/riscv-port-jdk17u/pull/15.diff