Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8287425: Remove unnecessary register push for MacroAssembler::check_klass_subtype_slow_path #16

Merged
merged 1 commit into from Mar 16, 2023

Conversation

zhengxiaolinX
Copy link
Collaborator

@zhengxiaolinX zhengxiaolinX commented Mar 16, 2023

This is another-half backport (RISC-V part only) of JDK-8287425. The original patch is at [1].

This patch can interestingly fix an issue with async-profiler [2], and has been backported to JDK17/JDK11u. But when backporting to JDK17, the RISC-V part of this patch was dropped [3] since we did not have the RISC-V backend. Now that we have the RISC-V port of JDK17, the missing part needs a backport as well.

Tested on unmatched, hotspot tier1~2 (fastdebug). More tiers are on the way.

[1] openjdk/jdk@b5a646e
[2] async-profiler/async-profiler#673 (comment)
[3] openjdk/jdk17u-dev#672


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8287425: Remove unnecessary register push for MacroAssembler::check_klass_subtype_slow_path

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/riscv-port-jdk17u pull/16/head:pull/16
$ git checkout pull/16

Update a local copy of the PR:
$ git checkout pull/16
$ git pull https://git.openjdk.org/riscv-port-jdk17u pull/16/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16

View PR using the GUI difftool:
$ git pr show -t 16

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/riscv-port-jdk17u/pull/16.diff

…lass_subtype_slow_path

Co-authored-by: Wei Kuai <kuaiwei.kw@alibaba-inc.com>
Reviewed-by: kvn
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 16, 2023

👋 Welcome back xlinzheng! A progress list of the required criteria for merging this PR into riscv-port will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b5a646ee6cfd432cef6b7e69a177959227a38ace 8287425: Remove unnecessary register push for MacroAssembler::check_klass_subtype_slow_path Mar 16, 2023
@openjdk
Copy link

openjdk bot commented Mar 16, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Mar 16, 2023
@mlbridge
Copy link

mlbridge bot commented Mar 16, 2023

Webrevs

Copy link
Member

@RealFYang RealFYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Thanks.

@RealFYang RealFYang merged commit d2025ab into openjdk:riscv-port Mar 16, 2023
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
2 participants