8301313: RISC-V: C2: assert(false) failed: bad AD file due to missing match rule

[DingliZhang]

Please review this backport to riscv-port-jdk17u.
Backport of JDK-8301313.
The original patch cannot be directly applied because of the line number, but there are no other additional changes.
The error C2: assert(false) failed mentioned in the original issue may require foreign api to reproduce, which is not available in jdk17u, but the same problem actually exists in jdk17u.

Testing:

• Tier1-3 passed without new failure on unmacthed (release).

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8301313: RISC-V: C2: assert(false) failed: bad AD file due to missing match rule

Reviewers

• Feilong Jiang (@feilongjiang - no project role) ⚠️ Review applies to e1706480

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/riscv-port-jdk17u.git pull/17/head:pull/17
$ git checkout pull/17

Update a local copy of the PR:
$ git checkout pull/17
$ git pull https://git.openjdk.org/riscv-port-jdk17u.git pull/17/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17

View PR using the GUI difftool:
$ git pr show -t 17

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/riscv-port-jdk17u/pull/17.diff

[bridgekeeper]

👋 Welcome back dzhang! A progress list of the required criteria for merging this PR into riscv-port will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 01: Full (47778b8e)
• 00: Full (e1706480)

[feilongjiang]

LGTM

[RealFYang]

I think you should backport fix for https://bugs.openjdk.org/browse/JDK-8299847 first which corrects 'ins_pipe' for the CMove nodes for RISC-V. That would help resolve the dependency here.

[DingliZhang]

I think you should backport fix for https://bugs.openjdk.org/browse/JDK-8299847 first which corrects 'ins_pipe' for the CMove nodes for RISC-V. That would help resolve the dependency here.

Thanks for pointing this out.
I'm currently testing JDK-8299847 and will create backport PR after that first.

[openjdk]

@DingliZhang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8301313: RISC-V: C2: assert(false) failed: bad AD file due to missing match rule

Reviewed-by: fjiang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the riscv-port branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[RealFYang]

OK. I see the C2 transformation code leading to the original issue is also there in jdk17u.