-
Notifications
You must be signed in to change notification settings - Fork 13
8299847: RISC-V: Improve PrintOptoAssembly output of CMoveI/L nodes #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8299847: RISC-V: Improve PrintOptoAssembly output of CMoveI/L nodes #18
Conversation
|
👋 Welcome back dzhang! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
Backport-of: 859ccd1a150653c42ebbcd3402994ef9ff4c810f
|
This backport pull request has now been updated with issue from the original commit. |
|
@DingliZhang This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
7ed1b5a to
9d94961
Compare
|
@DingliZhang Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
RealFYang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks.
Please review this backport to riscv-port-jdk17u.
Backport of JDK-8299847. Applies cleanly.
Testing:
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/riscv-port-jdk17u.git pull/18/head:pull/18$ git checkout pull/18Update a local copy of the PR:
$ git checkout pull/18$ git pull https://git.openjdk.org/riscv-port-jdk17u.git pull/18/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 18View PR using the GUI difftool:
$ git pr show -t 18Using diff file
Download this PR as a diff file:
https://git.openjdk.org/riscv-port-jdk17u/pull/18.diff