Skip to content

Conversation

@DingliZhang
Copy link
Member

@DingliZhang DingliZhang commented Mar 21, 2023

Please review this backport to riscv-port-jdk17u.
Backport of JDK-8299847. Applies cleanly.

Testing:

  • Tier1 passed without new failure on unmacthed (release).

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8299847: RISC-V: Improve PrintOptoAssembly output of CMoveI/L nodes

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/riscv-port-jdk17u.git pull/18/head:pull/18
$ git checkout pull/18

Update a local copy of the PR:
$ git checkout pull/18
$ git pull https://git.openjdk.org/riscv-port-jdk17u.git pull/18/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18

View PR using the GUI difftool:
$ git pr show -t 18

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/riscv-port-jdk17u/pull/18.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 21, 2023

👋 Welcome back dzhang! A progress list of the required criteria for merging this PR into riscv-port will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 3ad6aef1496de914b70f00005465e4b22f248d4f 8301313: RISC-V: C2: assert(false) failed: bad AD file due to missing match rule Mar 21, 2023
@openjdk
Copy link

openjdk bot commented Mar 21, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Mar 21, 2023
@mlbridge
Copy link

mlbridge bot commented Mar 21, 2023

Webrevs

Backport-of: 859ccd1a150653c42ebbcd3402994ef9ff4c810f
@DingliZhang DingliZhang changed the title 8301313: RISC-V: C2: assert(false) failed: bad AD file due to missing match rule Backport 859ccd1a150653c42ebbcd3402994ef9ff4c810f Mar 21, 2023
@openjdk openjdk bot changed the title Backport 859ccd1a150653c42ebbcd3402994ef9ff4c810f 8299847: RISC-V: Improve PrintOptoAssembly output of CMoveI/L nodes Mar 21, 2023
@openjdk
Copy link

openjdk bot commented Mar 21, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the clean Identical backport; no merge resolution required label Mar 21, 2023
@openjdk
Copy link

openjdk bot commented Mar 21, 2023

@DingliZhang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299847: RISC-V: Improve PrintOptoAssembly output of CMoveI/L nodes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the riscv-port branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 21, 2023
@DingliZhang DingliZhang force-pushed the backport-JDK-8299847 branch from 7ed1b5a to 9d94961 Compare March 21, 2023 01:32
@openjdk
Copy link

openjdk bot commented Mar 21, 2023

@DingliZhang Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

Copy link
Member

@RealFYang RealFYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@RealFYang RealFYang merged commit 4d4daec into openjdk:riscv-port Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants