Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8290164: compiler/runtime/TestConstantsInError.java fails on riscv #3

Merged
merged 1 commit into from Mar 2, 2023

Conversation

DingliZhang
Copy link
Member

@DingliZhang DingliZhang commented Mar 1, 2023

Please review this backport to riscv-port-jdk17u. Backport of JDK-8290164.
Since jdk17u does not have the patch JDK-8280473, there will be one less if to modify.

Testing:

  • compiler/runtime/TestConstantsInError.java passed on qemu and unmacthed.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8290164: compiler/runtime/TestConstantsInError.java fails on riscv

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/riscv-port-jdk17u pull/3/head:pull/3
$ git checkout pull/3

Update a local copy of the PR:
$ git checkout pull/3
$ git pull https://git.openjdk.org/riscv-port-jdk17u pull/3/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3

View PR using the GUI difftool:
$ git pr show -t 3

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/riscv-port-jdk17u/pull/3.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 1, 2023

👋 Welcome back dzhang! A progress list of the required criteria for merging this PR into riscv-port will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@DingliZhang DingliZhang changed the title backport 3471ac9a907780d894d05bd58cf883c4c8d8838d Backport 3471ac9a907780d894d05bd58cf883c4c8d8838d Mar 1, 2023
@openjdk openjdk bot changed the title Backport 3471ac9a907780d894d05bd58cf883c4c8d8838d 8290164: compiler/runtime/TestConstantsInError.java fails on riscv Mar 1, 2023
@openjdk
Copy link

openjdk bot commented Mar 1, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Mar 1, 2023
@mlbridge
Copy link

mlbridge bot commented Mar 1, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 1, 2023

@DingliZhang Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

Copy link
Member

@RealFYang RealFYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@RealFYang RealFYang merged commit efabbf8 into openjdk:riscv-port Mar 2, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
2 participants