Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8305512: RISC-V: Enable RVC extension by default on supported hardware #33

Merged
merged 1 commit into from Apr 4, 2023

Conversation

zhengxiaolinX
Copy link
Collaborator

@zhengxiaolinX zhengxiaolinX commented Apr 3, 2023

The last backported patch of RVC - to enable it by default.

Although, we don't have UseRVA20U64 in jdk17, so I only made UseRVC true here. Looking forward to some opinions about it.

Tested hotspot tier1~4 with fastdebug build.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8305512: RISC-V: Enable RVC extension by default on supported hardware

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/riscv-port-jdk17u.git pull/33/head:pull/33
$ git checkout pull/33

Update a local copy of the PR:
$ git checkout pull/33
$ git pull https://git.openjdk.org/riscv-port-jdk17u.git pull/33/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 33

View PR using the GUI difftool:
$ git pr show -t 33

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/riscv-port-jdk17u/pull/33.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 3, 2023

👋 Welcome back xlinzheng! A progress list of the required criteria for merging this PR into riscv-port will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 38eb80d4d89cf45cd0c8422525121dcb62a1e999 8296975: RISC-V: Enable UseRVA20U64 profile by default Apr 3, 2023
@openjdk
Copy link

openjdk bot commented Apr 3, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Apr 3, 2023
@mlbridge
Copy link

mlbridge bot commented Apr 3, 2023

Webrevs

Copy link
Member

@RealFYang RealFYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK.

@RealFYang
Copy link
Member

RealFYang commented Apr 4, 2023

@zhengxiaolinX : I feel it might be better to create new repo-specific JBS issue for this. The title could be something like: "RISC-V: Enable RVC extension by default on supported hardware". And the JBS version should be repo-riscv-port-17 which has been created recently.

@zhengxiaolinX zhengxiaolinX changed the title 8296975: RISC-V: Enable UseRVA20U64 profile by default 8305512: RISC-V: Enable RVC extension by default on supported hardware Apr 4, 2023
@zhengxiaolinX
Copy link
Collaborator Author

/remove backport

@openjdk
Copy link

openjdk bot commented Apr 4, 2023

@zhengxiaolinX Unknown command remove - for a list of valid commands use /help.

@zhengxiaolinX
Copy link
Collaborator Author

zhengxiaolinX commented Apr 4, 2023

@zhengxiaolinX : I feel it might be better to create new repo-specific JBS issue for this. The title could be something like: "RISC-V: Enable RVC extension by default on supported hardware". And the JBS version should be repo-riscv-port-17 which has been created recently.

Thanks for the advice, which sounds very reasonable. I have created the other issue and changed the title.
Although I cannot find a proper way to remove the backport label from the skara guide [1].

As the owner of this repo, could you please help to remove the label? Thank you.

[1] https://wiki.openjdk.org/display/SKARA/Pull+Request+Commands

@RealFYang RealFYang removed the backport label Apr 4, 2023
@RealFYang
Copy link
Member

@zhengxiaolinX : I feel it might be better to create new repo-specific JBS issue for this. The title could be something like: "RISC-V: Enable RVC extension by default on supported hardware". And the JBS version should be repo-riscv-port-17 which has been created recently.

Thanks for the advice, which sounds very reasonable. I have created the other issue and changed the title. Although I cannot find a proper way to remove the backport label from the skara guide [1].

As the owner of this repo, could you please help to remove the label? Thank you.

[1] https://wiki.openjdk.org/display/SKARA/Pull+Request+Commands

Yeah, we should remove the backport label for this. I have done that for you. Thanks.

@RealFYang RealFYang merged commit 8040e76 into openjdk:riscv-port Apr 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Pull request is ready for review
2 participants