Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8293474: RISC-V: Unify the way of moving function pointer #35

Merged
merged 1 commit into from Apr 6, 2023

Conversation

DingliZhang
Copy link
Member

@DingliZhang DingliZhang commented Apr 5, 2023

Please review this backport to riscv-port-jdk17u.
Backport of JDK-8293474.
The original patch cannot be directly applied because of #32 , and there are no other additional changes.

Testing:

  • Tier1-3 passed without new failure on unmacthed (release).

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Error

 ⚠️ This PR only contains changes already present in the target

Issue

  • JDK-8293474: RISC-V: Unify the way of moving function pointer

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/riscv-port-jdk17u.git pull/35/head:pull/35
$ git checkout pull/35

Update a local copy of the PR:
$ git checkout pull/35
$ git pull https://git.openjdk.org/riscv-port-jdk17u.git pull/35/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 35

View PR using the GUI difftool:
$ git pr show -t 35

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/riscv-port-jdk17u/pull/35.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 5, 2023

👋 Welcome back dzhang! A progress list of the required criteria for merging this PR into riscv-port will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport fc5f97fe379825cb927666ae26aef00082cfae56 8293474: RISC-V: Unify the way of moving function pointer Apr 5, 2023
@openjdk
Copy link

openjdk bot commented Apr 5, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Apr 5, 2023
@mlbridge
Copy link

mlbridge bot commented Apr 5, 2023

Webrevs

Copy link
Member

@RealFYang RealFYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@RealFYang RealFYang merged commit a078187 into openjdk:riscv-port Apr 6, 2023
1 check passed
@openjdk openjdk bot removed the rfr Pull request is ready for review label Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 participants