Skip to content

8294430: RISC-V: Small refactoring for movptr_with_offset #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

DingliZhang
Copy link
Member

@DingliZhang DingliZhang commented Apr 6, 2023

Please review this backport to riscv-port-jdk17u.
Backport of JDK-8294430.
The original patch cannot be directly applied because jdk17u has no emit_entry_barrier_stub, which introduced with JDK-8293007, and there are no other additional changes.

Testing:

  • Tier1-3 passed without new failure on unmacthed (release).

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8294430: RISC-V: Small refactoring for movptr_with_offset

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/riscv-port-jdk17u.git pull/36/head:pull/36
$ git checkout pull/36

Update a local copy of the PR:
$ git checkout pull/36
$ git pull https://git.openjdk.org/riscv-port-jdk17u.git pull/36/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 36

View PR using the GUI difftool:
$ git pr show -t 36

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/riscv-port-jdk17u/pull/36.diff

Webrev

Link to Webrev Comment

@DingliZhang DingliZhang changed the title 8294430: RISC-V: Small refactoring for movptr_with_offset Backport d827fd830afda58e30b667e61fc4653423db9d39 Apr 6, 2023
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 6, 2023

👋 Welcome back dzhang! A progress list of the required criteria for merging this PR into riscv-port will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d827fd830afda58e30b667e61fc4653423db9d39 8294430: RISC-V: Small refactoring for movptr_with_offset Apr 6, 2023
@openjdk
Copy link

openjdk bot commented Apr 6, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Apr 6, 2023
@mlbridge
Copy link

mlbridge bot commented Apr 6, 2023

Webrevs

Copy link
Member

@RealFYang RealFYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@RealFYang RealFYang merged commit dab3ec4 into openjdk:riscv-port Apr 7, 2023
@lgxbslgx
Copy link
Member

lgxbslgx commented Apr 7, 2023

I recieved a Withdrawn email because the PR is merged by using the GitHub UI instead of using the command /integrate. It is good to obey the OpenJDK dev flow and use the command /integrate because it would do some checks and avoid the unnecessary/wrong information, such as the Withdrawn email.

@RealFYang
Copy link
Member

I recieved a Withdrawn email because the PR is merged by using the GitHub UI instead of using the command /integrate. It is good to obey the OpenJDK dev flow and use the command /integrate because it would do some checks and avoid the unnecessary/wrong information, such as the Withdrawn email.

Yeah, I think you are right. This also remind me that the project in .jcheck/conf for the riscv-port branch of this repo should be updated to riscv-port like we do for [1]. I have done this configuration and I think we can now switch to the normal dev flow for our future backport PRs.

[1] https://github.com/openjdk/riscv-port/tree/riscv-port

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

4 participants