New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8293100: RISC-V: Need to save and restore callee-saved FloatRegisters in StubGenerator::generate_call_stub #4
Conversation
|
This backport pull request has now been updated with issue from the original commit. |
@zifeihan This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@VladimirKempik, @RealFYang) but any other Committer may sponsor as well.
|
78243db
to
16f999a
Compare
@zifeihan Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for backporting this!
Please review this backport to riscv-port-jdk17u. Backport of JDK-8293100.
The original patch cannot be directly applied because of the line number, but there are no other additional changes.
Testing:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/riscv-port-jdk17u pull/4/head:pull/4
$ git checkout pull/4
Update a local copy of the PR:
$ git checkout pull/4
$ git pull https://git.openjdk.org/riscv-port-jdk17u pull/4/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4
View PR using the GUI difftool:
$ git pr show -t 4
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/riscv-port-jdk17u/pull/4.diff