Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8293050: RISC-V: Remove redundant non-null assertions about macro-assembler #40

Closed
wants to merge 1 commit into from

Conversation

zifeihan
Copy link
Member

@zifeihan zifeihan commented Apr 11, 2023

Please review this backport to riscv-port-jdk17u.
Backport of JDK-8293050.

No other changes, build success.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8293050: RISC-V: Remove redundant non-null assertions about macro-assembler

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/riscv-port-jdk17u.git pull/40/head:pull/40
$ git checkout pull/40

Update a local copy of the PR:
$ git checkout pull/40
$ git pull https://git.openjdk.org/riscv-port-jdk17u.git pull/40/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 40

View PR using the GUI difftool:
$ git pr show -t 40

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/riscv-port-jdk17u/pull/40.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 11, 2023

👋 Welcome back gcao! A progress list of the required criteria for merging this PR into riscv-port will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 38e670631587853d0f2b5cad48f8ddbce46cecdb 8293050: RISC-V: Remove redundant non-null assertions about macro-assembler Apr 11, 2023
@openjdk
Copy link

openjdk bot commented Apr 11, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 11, 2023

@zifeihan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293050: RISC-V: Remove redundant non-null assertions about macro-assembler

Reviewed-by: fyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the riscv-port branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 11, 2023
@mlbridge
Copy link

mlbridge bot commented Apr 11, 2023

Webrevs

@zifeihan
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 12, 2023
@openjdk
Copy link

openjdk bot commented Apr 12, 2023

@zifeihan
Your change (at version fc2d9fe) is now ready to be sponsored by a Committer.

@RealFYang
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 12, 2023

Going to push as commit e569c04.
Since your change was applied there has been 1 commit pushed to the riscv-port branch:

  • 12e5b84: 8295968: RISC-V: Rename some assembler intrinsic functions for RVV 1.0

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 12, 2023
@openjdk openjdk bot closed this Apr 12, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 12, 2023
@openjdk
Copy link

openjdk bot commented Apr 12, 2023

@RealFYang @zifeihan Pushed as commit e569c04.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@zifeihan zifeihan deleted the backport-JDK-8293050 branch February 28, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants