-
Notifications
You must be signed in to change notification settings - Fork 13
8307150: RISC-V: Remove remaining StoreLoad barrier with UseCondCardMark for Serial/Parallel GC #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ark for Serial/Parallel GC
|
👋 Welcome back fjiang! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
|
@feilongjiang This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
RealFYang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. We should have this so that we are on-par with other CPUs like aarch64.
|
@RealFYang -- Thanks for the review. |
|
@feilongjiang |
|
/sponsor |
|
Going to push as commit 504014c.
Your commit was automatically rebased without conflicts. |
|
@RealFYang @feilongjiang Pushed as commit 504014c. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi,
Please review this clean backport of JDK-8307150 to riscv-port-jdk17u.
Same as the mainline, this
StoreLoadbarrier is no longer needed after the removal of CMS.Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/riscv-port-jdk17u.git pull/55/head:pull/55$ git checkout pull/55Update a local copy of the PR:
$ git checkout pull/55$ git pull https://git.openjdk.org/riscv-port-jdk17u.git pull/55/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 55View PR using the GUI difftool:
$ git pr show -t 55Using diff file
Download this PR as a diff file:
https://git.openjdk.org/riscv-port-jdk17u/pull/55.diff
Webrev
Link to Webrev Comment