Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8307651: RISC-V: stringL_indexof_char instruction has wrong format string #56

Closed

Conversation

feilongjiang
Copy link
Member

@feilongjiang feilongjiang commented May 22, 2023

Hi,
Please review this clean backport of JDK-8307651 to riscv-port-jdk17u.

backport is trivial since it only modifies some format of C2 string instructs.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8307651: RISC-V: stringL_indexof_char instruction has wrong format string

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/riscv-port-jdk17u.git pull/56/head:pull/56
$ git checkout pull/56

Update a local copy of the PR:
$ git checkout pull/56
$ git pull https://git.openjdk.org/riscv-port-jdk17u.git pull/56/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 56

View PR using the GUI difftool:
$ git pr show -t 56

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/riscv-port-jdk17u/pull/56.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 22, 2023

👋 Welcome back fjiang! A progress list of the required criteria for merging this PR into riscv-port will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d3e6d04e3eddfd26433f9cb95cfa9bff05b14bd6 8307651: RISC-V: stringL_indexof_char instruction has wrong format string May 22, 2023
@openjdk
Copy link

openjdk bot commented May 22, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 22, 2023

@feilongjiang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8307651: RISC-V: stringL_indexof_char instruction has wrong format string

Reviewed-by: fyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the riscv-port branch:

  • c24cc2a: 8301036: RISC-V: Factor out functions baseOffset & baseOffset32 from MacroAssembler
  • 1422604: 8297697: RISC-V: Add support for SATP mode detection

Please see this link for an up-to-date comparison between the source branch of this pull request and the riscv-port branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 22, 2023
@mlbridge
Copy link

mlbridge bot commented May 22, 2023

Webrevs

@feilongjiang
Copy link
Member Author

@RealFYang -- Thanks!
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 23, 2023
@openjdk
Copy link

openjdk bot commented May 23, 2023

@feilongjiang
Your change (at version cfa6bc4) is now ready to be sponsored by a Committer.

@RealFYang
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented May 23, 2023

Going to push as commit 9d8c08f.
Since your change was applied there have been 3 commits pushed to the riscv-port branch:

  • 504014c: 8307150: RISC-V: Remove remaining StoreLoad barrier with UseCondCardMark for Serial/Parallel GC
  • c24cc2a: 8301036: RISC-V: Factor out functions baseOffset & baseOffset32 from MacroAssembler
  • 1422604: 8297697: RISC-V: Add support for SATP mode detection

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 23, 2023
@openjdk openjdk bot closed this May 23, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 23, 2023
@openjdk
Copy link

openjdk bot commented May 23, 2023

@RealFYang @feilongjiang Pushed as commit 9d8c08f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@feilongjiang feilongjiang deleted the backport-JDK-8307651 branch May 23, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants