8294083: RISC-V: Minimal build failed with --disable-precompiled-headers #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review this backport to riscv-port-jdk17u.
Backport of JDK-8294083.
Compared to the original patch, the addition of including the corresponding header (gc/shared/collectedHeap.hpp) fix the invalid use of incomplete type 'class CollectedHeap' as follows:
In addition to that, we need JDK-8295468 to fix the minimal build of fastdebug.
Testing: Minimal builds with this fix
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/riscv-port-jdk17u pull/6/head:pull/6
$ git checkout pull/6
Update a local copy of the PR:
$ git checkout pull/6
$ git pull https://git.openjdk.org/riscv-port-jdk17u pull/6/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 6
View PR using the GUI difftool:
$ git pr show -t 6
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/riscv-port-jdk17u/pull/6.diff