Skip to content

8305728: RISC-V: Use bexti instruction to do single-bit testing#65

Closed
DingliZhang wants to merge 1 commit intoopenjdk:riscv-portfrom
DingliZhang:backport-JDK-8305728
Closed

8305728: RISC-V: Use bexti instruction to do single-bit testing#65
DingliZhang wants to merge 1 commit intoopenjdk:riscv-portfrom
DingliZhang:backport-JDK-8305728

Conversation

@DingliZhang
Copy link
Member

@DingliZhang DingliZhang commented Jun 1, 2023

Hi, please review this backport to riscv-port-jdk17u.
Backport of JDK-8305728. The original patch cannot be directly applied because jdk17u has no JDK-8299089 and JDK-8301995.

Testing:

  • tier1-3 tests on QEMU-System w/ and w/o UseZbs (release build)
  • tier1-3 tests on unmatched board w/o UseZbs (release build)

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8305728: RISC-V: Use bexti instruction to do single-bit testing

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/riscv-port-jdk17u.git pull/65/head:pull/65
$ git checkout pull/65

Update a local copy of the PR:
$ git checkout pull/65
$ git pull https://git.openjdk.org/riscv-port-jdk17u.git pull/65/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 65

View PR using the GUI difftool:
$ git pr show -t 65

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/riscv-port-jdk17u/pull/65.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 1, 2023

👋 Welcome back dzhang! A progress list of the required criteria for merging this PR into riscv-port will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 137513025dad06fc08818fa832edb4a487298f81 8305728: RISC-V: Use bexti instruction to do single-bit testing Jun 1, 2023
@openjdk
Copy link

openjdk bot commented Jun 1, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Jun 1, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 1, 2023

Webrevs

Copy link
Member

@RealFYang RealFYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@openjdk
Copy link

openjdk bot commented Jun 2, 2023

@DingliZhang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8305728: RISC-V: Use bexti instruction to do single-bit testing

Reviewed-by: fjiang, fyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the riscv-port branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 2, 2023
@DingliZhang
Copy link
Member Author

Thanks for the review!
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 5, 2023
@openjdk
Copy link

openjdk bot commented Jun 5, 2023

@DingliZhang
Your change (at version 360ed75) is now ready to be sponsored by a Committer.

@RealFYang
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jun 5, 2023

Going to push as commit 170152a.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 5, 2023
@openjdk openjdk bot closed this Jun 5, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 5, 2023
@openjdk
Copy link

openjdk bot commented Jun 5, 2023

@RealFYang @DingliZhang Pushed as commit 170152a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants