Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277440: riscv: Move UseVExt from product to experimental #11

Closed
wants to merge 2 commits into from

Conversation

yhzhu20
Copy link

@yhzhu20 yhzhu20 commented Nov 19, 2021

Currently, riscv port supports vector operations which is fully compatible with vector extension 1.0 spec. And we have passed tier 1-4 tests with option "-XX:+UseVExt" with QEMU.

Due to lack of native environment which supports vector extension 1.0, we cannot carry out tests for vector operations on real hardware. So we decided to move port-specific option UseVExt from product to experimental for now, and rename UseVExt to UseRVV.

This also fixes some typos in comments, and removes unused v extension instructions.

The test results on HiFive Unleashed board (rv64imafdc) and NeZha D1 board (rv64imafdcvu) are in line with expectations.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8277440: riscv: Move UseVExt from product to experimental

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/riscv-port pull/11/head:pull/11
$ git checkout pull/11

Update a local copy of the PR:
$ git checkout pull/11
$ git pull https://git.openjdk.java.net/riscv-port pull/11/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11

View PR using the GUI difftool:
$ git pr show -t 11

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/riscv-port/pull/11.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 19, 2021

👋 Welcome back yzhu! A progress list of the required criteria for merging this PR into riscv-port will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@yhzhu20 yhzhu20 changed the title Move UseVExt from product to experimental 8277440: riscv: Move UseVExt from product to experimental Nov 19, 2021
@openjdk openjdk bot added the rfr label Nov 19, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 19, 2021

Webrevs

Copy link
Collaborator

@yadongw yadongw left a comment

lgtm

Copy link
Member

@RealFYang RealFYang left a comment

Thanks for cleanup. Looks good.

@yhzhu20
Copy link
Author

@yhzhu20 yhzhu20 commented Nov 19, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Nov 19, 2021

@yhzhu20 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277440: riscv: Move UseVExt from product to experimental

Reviewed-by: yadongwang, fyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the riscv-port branch:

  • 398cec3: 8277392: riscv: Port missing trampoline logic from AArch64 platform

Please see this link for an up-to-date comparison between the source branch of this pull request and the riscv-port branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Nov 19, 2021
@RealFYang
Copy link
Member

@RealFYang RealFYang commented Nov 19, 2021

/sponsor

@openjdk openjdk bot added the sponsor label Nov 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 19, 2021

@yhzhu20
Your change (at version 5283eec) is now ready to be sponsored by a Committer.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 19, 2021

Going to push as commit dfde4e4.
Since your change was applied there has been 1 commit pushed to the riscv-port branch:

  • 398cec3: 8277392: riscv: Port missing trampoline logic from AArch64 platform

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 19, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Nov 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 19, 2021

@RealFYang @yhzhu20 Pushed as commit dfde4e4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated
3 participants