Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8278832: riscv: Inconsistency of Java frame offset definition in jdk.hotspot.agent #30

Closed
wants to merge 1 commit into from

Conversation

feilongjiang
Copy link
Member

@feilongjiang feilongjiang commented Dec 15, 2021

The Java frame definition was refactored in openjdk/jdk-sandbox@db24157 to make Java frame offset the same as C frame. In jdk.hotspot.agent, there is another Java frame definition based on the old Java frame offset, which causes jstack stack walking error. These definitions should also be updated.

Two tests passed after this fixing:

  • test/hotspot/jtreg/serviceability/sa/ClhsdbCDSCore.java
  • test/hotspot/jtreg/serviceability/sa/ClhsdbFindPC.java

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8278832: riscv: Inconsistency of Java frame offset definition in jdk.hotspot.agent

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/riscv-port pull/30/head:pull/30
$ git checkout pull/30

Update a local copy of the PR:
$ git checkout pull/30
$ git pull https://git.openjdk.java.net/riscv-port pull/30/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30

View PR using the GUI difftool:
$ git pr show -t 30

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/riscv-port/pull/30.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 15, 2021

👋 Welcome back fjiang! A progress list of the required criteria for merging this PR into riscv-port will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Dec 15, 2021
@mlbridge
Copy link

mlbridge bot commented Dec 15, 2021

Webrevs

Copy link
Collaborator

@yadongw yadongw left a comment

lgtm

Copy link

@yhzhu20 yhzhu20 left a comment

Looks good.

@openjdk
Copy link

openjdk bot commented Dec 15, 2021

@feilongjiang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278832: riscv: Inconsistency of Java frame offset definition in jdk.hotspot.agent

Reviewed-by: yadongwang, yzhu, fyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the riscv-port branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Dec 15, 2021
@feilongjiang
Copy link
Member Author

feilongjiang commented Dec 15, 2021

/integrate

@openjdk openjdk bot added the sponsor label Dec 15, 2021
@openjdk
Copy link

openjdk bot commented Dec 15, 2021

@feilongjiang
Your change (at version 871df01) is now ready to be sponsored by a Committer.

@RealFYang
Copy link
Member

RealFYang commented Dec 15, 2021

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 15, 2021

Going to push as commit 58dff3e.

@openjdk openjdk bot added the integrated label Dec 15, 2021
@openjdk openjdk bot closed this Dec 15, 2021
@openjdk openjdk bot removed ready rfr sponsor labels Dec 15, 2021
@openjdk
Copy link

openjdk bot commented Dec 15, 2021

@RealFYang @feilongjiang Pushed as commit 58dff3e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@feilongjiang feilongjiang deleted the fix-frame branch Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated
4 participants