Skip to content

8279292: riscv: Intrinsify multiplyToLen and squareToLen #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

feilongjiang
Copy link
Member

@feilongjiang feilongjiang commented Dec 27, 2021

BigInteger intrinsic: MultiplyToLen and SquareToLen intrinsic are missed in current vm. They should be implemented.
The JMH tests show that the MultiplyToLen intrinsic improve the performance by up to 2x ~ 3x and the SquareToLen intrinsic improve the performance by up to 1.8x ~ 2x when the length of BigInteger changed from 1 to 5000, compared with that of C2.

Full jtreg tests on qemu and hotspot/jdk tier1 test on Unmathced are passed without new failures.

JMH tests and results on D1 and Unmatched list as follows:
MyBenchmark.txt

squareToLen_unmatched.txt
squareToLen_d1.txt
multiplyToLen_unmatched.txt
multiplyToLen_d1.txt


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8279292: riscv: Intrinsify multiplyToLen and squareToLen

Reviewers

Contributors

  • Taiping Guo <guotaiping1@huawei.com>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/riscv-port pull/38/head:pull/38
$ git checkout pull/38

Update a local copy of the PR:
$ git checkout pull/38
$ git pull https://git.openjdk.java.net/riscv-port pull/38/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 38

View PR using the GUI difftool:
$ git pr show -t 38

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/riscv-port/pull/38.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 27, 2021

👋 Welcome back fjiang! A progress list of the required criteria for merging this PR into riscv-port will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 27, 2021
@feilongjiang
Copy link
Member Author

/contributor add Taiping Guo guotaiping1@huawei.com

@mlbridge
Copy link

mlbridge bot commented Dec 27, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 27, 2021

@feilongjiang
Contributor Taiping Guo <guotaiping1@huawei.com> successfully added.

@feilongjiang
Copy link
Member Author

feilongjiang commented Dec 27, 2021

@RealFYang Thank you for the review. I have addressed all your comments above. :-)

Copy link
Member

@RealFYang RealFYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Dec 29, 2021

@feilongjiang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8279292: riscv: Intrinsify multiplyToLen and squareToLen

Co-authored-by: Taiping Guo <guotaiping1@huawei.com>
Reviewed-by: fyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the riscv-port branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 29, 2021
@feilongjiang
Copy link
Member Author

/integrate

@RealFYang
Copy link
Member

/sponsor

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 29, 2021
@openjdk
Copy link

openjdk bot commented Dec 29, 2021

@feilongjiang
Your change (at version aca73fb) is now ready to be sponsored by a Committer.

@openjdk
Copy link

openjdk bot commented Dec 29, 2021

Going to push as commit b396cdd.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 29, 2021
@openjdk openjdk bot closed this Dec 29, 2021
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 29, 2021
@openjdk
Copy link

openjdk bot commented Dec 29, 2021

@RealFYang @feilongjiang Pushed as commit b396cdd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@feilongjiang feilongjiang deleted the multolen-squaretolen branch January 11, 2022 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants