-
Notifications
You must be signed in to change notification settings - Fork 19
8279292: riscv: Intrinsify multiplyToLen and squareToLen #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8279292: riscv: Intrinsify multiplyToLen and squareToLen #38
Conversation
👋 Welcome back fjiang! A progress list of the required criteria for merging this PR into |
/contributor add Taiping Guo guotaiping1@huawei.com |
Webrevs
|
@feilongjiang |
@RealFYang Thank you for the review. I have addressed all your comments above. :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@feilongjiang This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
/sponsor |
@feilongjiang |
Going to push as commit b396cdd. |
@RealFYang @feilongjiang Pushed as commit b396cdd. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
BigInteger intrinsic: MultiplyToLen and SquareToLen intrinsic are missed in current vm. They should be implemented.
The JMH tests show that the MultiplyToLen intrinsic improve the performance by up to 2x ~ 3x and the SquareToLen intrinsic improve the performance by up to 1.8x ~ 2x when the length of BigInteger changed from 1 to 5000, compared with that of C2.
Full jtreg tests on qemu and hotspot/jdk tier1 test on Unmathced are passed without new failures.
JMH tests and results on D1 and Unmatched list as follows:
MyBenchmark.txt
squareToLen_unmatched.txt
squareToLen_d1.txt
multiplyToLen_unmatched.txt
multiplyToLen_d1.txt
Progress
Issue
Reviewers
Contributors
<guotaiping1@huawei.com>
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/riscv-port pull/38/head:pull/38
$ git checkout pull/38
Update a local copy of the PR:
$ git checkout pull/38
$ git pull https://git.openjdk.java.net/riscv-port pull/38/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 38
View PR using the GUI difftool:
$ git pr show -t 38
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/riscv-port/pull/38.diff