8280497: riscv: Undefined Behaviour in class Assembler

[yadongw]

The same problem exists on the riscv platfom. So we follow https://bugs.openjdk.java.net/browse/JDK-8276563.

All instances of type Register exhibit UB in the form of wild pointer (including null pointer) dereferences. This isn't very hard to fix: we should make Registers pointer to something rather than aliases of small integers.

Hotspot/jdk tier1 were passed on the unmatched board. And all jtreg tests have been tested on Qemu without new failures.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8280497: riscv: Undefined Behaviour in class Assembler

Reviewers

• Fei Yang (@RealFYang - Reviewer)
• Feilong Jiang (@feilongjiang - Author)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/riscv-port pull/53/head:pull/53
$ git checkout pull/53

Update a local copy of the PR:
$ git checkout pull/53
$ git pull https://git.openjdk.java.net/riscv-port pull/53/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 53

View PR using the GUI difftool:
$ git pr show -t 53

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/riscv-port/pull/53.diff

[bridgekeeper]

👋 Welcome back yadongwang! A progress list of the required criteria for merging this PR into riscv-port will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 01: Full - Incremental (27ecc023)
• 00: Full (8e61f40c)

[openjdk]

@yadongw This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8280497: riscv: Undefined Behaviour in class Assembler

Reviewed-by: fyang, fjiang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the riscv-port branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the riscv-port branch, type /integrate in a new comment.

[yadongw]

/integrate

[openjdk]

Going to push as commit 65852a6.
Since your change was applied there have been 19 commits pushed to the riscv-port branch:

• 068f5d5: Merge branch 'master' into riscv-port
• c2ee1b3: 8273236: keytool does not accurately warn about algorithms that are disabled but have additional constraints
• 16e0ad0: 8270199: Most SA tests are skipped on macosx-aarch64 because all executables are signed
• d2a50a6: 8279636: Update JCov version to 3.0.12
• b5de2cc: 8280546: Remove hard-coded 127.0.0.1 loopback address
• 0c42e43: 8280550: SplittableRandom#nextDouble(double,double) can return result >= bound
• a5a11f1: Merge
• ef08e2c: 8280592: Small javadoc tweaks to foreign API
• b8365aa: 8268978: Document the javadoc software stack
• 4b2370e: 8279294: NonblockingQueue::try_pop may improperly indicate queue is empty
• ... and 9 more: https://git.openjdk.java.net/riscv-port/compare/1a31f9f3547bad09e1cec8a211a6e0d3211bac6a...riscv-port

Your commit was automatically rebased without conflicts.

[openjdk]

@yadongw Pushed as commit 65852a6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.