Skip to content

Commit

Permalink
8334315: Shenandoah: reduce GC logging noise
Browse files Browse the repository at this point in the history
Reviewed-by: ysr
Backport-of: f35af7171213c09107b99104a73022853bff91b0
  • Loading branch information
William Kemper committed Sep 30, 2024
1 parent d1d530a commit e8f1584
Showing 1 changed file with 22 additions and 22 deletions.
44 changes: 22 additions & 22 deletions src/hotspot/share/gc/shenandoah/shenandoahFreeSet.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -54,25 +54,25 @@ static const char* partition_name(ShenandoahFreeSetPartitionId t) {

#ifndef PRODUCT
void ShenandoahRegionPartitions::dump_bitmap() const {
log_info(gc)("Mutator range [" SSIZE_FORMAT ", " SSIZE_FORMAT "], Collector range [" SSIZE_FORMAT ", " SSIZE_FORMAT
"], Old Collector range [" SSIZE_FORMAT ", " SSIZE_FORMAT "]",
_leftmosts[int(ShenandoahFreeSetPartitionId::Mutator)],
_rightmosts[int(ShenandoahFreeSetPartitionId::Mutator)],
_leftmosts[int(ShenandoahFreeSetPartitionId::Collector)],
_rightmosts[int(ShenandoahFreeSetPartitionId::Collector)],
_leftmosts[int(ShenandoahFreeSetPartitionId::OldCollector)],
_rightmosts[int(ShenandoahFreeSetPartitionId::OldCollector)]);
log_info(gc)("Empty Mutator range [" SSIZE_FORMAT ", " SSIZE_FORMAT
"], Empty Collector range [" SSIZE_FORMAT ", " SSIZE_FORMAT
"], Empty Old Collecto range [" SSIZE_FORMAT ", " SSIZE_FORMAT "]",
_leftmosts_empty[int(ShenandoahFreeSetPartitionId::Mutator)],
_rightmosts_empty[int(ShenandoahFreeSetPartitionId::Mutator)],
_leftmosts_empty[int(ShenandoahFreeSetPartitionId::Collector)],
_rightmosts_empty[int(ShenandoahFreeSetPartitionId::Collector)],
_leftmosts_empty[int(ShenandoahFreeSetPartitionId::OldCollector)],
_rightmosts_empty[int(ShenandoahFreeSetPartitionId::OldCollector)]);

log_info(gc)("%6s: %18s %18s %18s %18s", "index", "Mutator Bits", "Collector Bits", "Old Collector Bits", "NotFree Bits");
log_debug(gc)("Mutator range [" SSIZE_FORMAT ", " SSIZE_FORMAT "], Collector range [" SSIZE_FORMAT ", " SSIZE_FORMAT
"], Old Collector range [" SSIZE_FORMAT ", " SSIZE_FORMAT "]",
_leftmosts[int(ShenandoahFreeSetPartitionId::Mutator)],
_rightmosts[int(ShenandoahFreeSetPartitionId::Mutator)],
_leftmosts[int(ShenandoahFreeSetPartitionId::Collector)],
_rightmosts[int(ShenandoahFreeSetPartitionId::Collector)],
_leftmosts[int(ShenandoahFreeSetPartitionId::OldCollector)],
_rightmosts[int(ShenandoahFreeSetPartitionId::OldCollector)]);
log_debug(gc)("Empty Mutator range [" SSIZE_FORMAT ", " SSIZE_FORMAT
"], Empty Collector range [" SSIZE_FORMAT ", " SSIZE_FORMAT
"], Empty Old Collecto range [" SSIZE_FORMAT ", " SSIZE_FORMAT "]",
_leftmosts_empty[int(ShenandoahFreeSetPartitionId::Mutator)],
_rightmosts_empty[int(ShenandoahFreeSetPartitionId::Mutator)],
_leftmosts_empty[int(ShenandoahFreeSetPartitionId::Collector)],
_rightmosts_empty[int(ShenandoahFreeSetPartitionId::Collector)],
_leftmosts_empty[int(ShenandoahFreeSetPartitionId::OldCollector)],
_rightmosts_empty[int(ShenandoahFreeSetPartitionId::OldCollector)]);

log_debug(gc)("%6s: %18s %18s %18s %18s", "index", "Mutator Bits", "Collector Bits", "Old Collector Bits", "NotFree Bits");
dump_bitmap_range(0, _max-1);
}

Expand All @@ -96,8 +96,8 @@ void ShenandoahRegionPartitions::dump_bitmap_row(idx_t region_idx) const {
uintx old_collector_bits = _membership[int(ShenandoahFreeSetPartitionId::OldCollector)].bits_at(aligned_idx);
uintx free_bits = mutator_bits | collector_bits | old_collector_bits;
uintx notfree_bits = ~free_bits;
log_info(gc)(SSIZE_FORMAT_W(6) ": " SIZE_FORMAT_X_0 " 0x" SIZE_FORMAT_X_0 " 0x" SIZE_FORMAT_X_0 " 0x" SIZE_FORMAT_X_0,
aligned_idx, mutator_bits, collector_bits, old_collector_bits, notfree_bits);
log_debug(gc)(SSIZE_FORMAT_W(6) ": " SIZE_FORMAT_X_0 " 0x" SIZE_FORMAT_X_0 " 0x" SIZE_FORMAT_X_0 " 0x" SIZE_FORMAT_X_0,
aligned_idx, mutator_bits, collector_bits, old_collector_bits, notfree_bits);
}
#endif

Expand Down Expand Up @@ -1507,7 +1507,7 @@ void ShenandoahFreeSet::move_regions_from_collector_to_mutator(size_t max_xfer_r
}

size_t total_xfer = collector_xfer + old_collector_xfer;
log_info(gc, free)("At start of update refs, moving " SIZE_FORMAT "%s to Mutator free set from Collector Reserve ("
log_info(gc, ergo)("At start of update refs, moving " SIZE_FORMAT "%s to Mutator free set from Collector Reserve ("
SIZE_FORMAT "%s) and from Old Collector Reserve (" SIZE_FORMAT "%s)",
byte_size_in_proper_unit(total_xfer), proper_unit_for_byte_size(total_xfer),
byte_size_in_proper_unit(collector_xfer), proper_unit_for_byte_size(collector_xfer),
Expand Down

0 comments on commit e8f1584

Please sign in to comment.